Handle metapackages that cannot be installed #16788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
approved these changes
Feb 17, 2021
praveenkuttappan
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
|
@chidozieononiwu : This is the PR we talked about regarding changes to reduce package parsing iterations. |
| $setupProps = (python -c "import sys; import os; sys.path.append(os.path.join('scripts', 'devops_tasks')); from common_tasks import get_package_properties; obj=get_package_properties('$setupLocation'); print('{0},{1},{2}'.format(obj[0], obj[1], obj[2]));") -split "," | ||
| $setupProps = $null | ||
| try{ | ||
| pip install packaging==20.4 -q -I |
There was a problem hiding this comment.
Did you intend to move this out so its only installed once?
There was a problem hiding this comment.
Nope. It attempts to install for every package as opposed to every iteration. But we can move this completely outside too.
There was a problem hiding this comment.
I think an issue in that approach will be additional constraint to have python installed if anyone wants to use any other functions in this script. For now, I will leave as it is since this change alone has improved performance a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set package properties and handle meta package errors when parsing properties