-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventHubs] update vendor storage blob code #16559
[EventHubs] update vendor storage blob code #16559
Conversation
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
5ee520f
to
d646191
Compare
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
...ure/eventhub/extensions/checkpointstoreblobaio/_vendor/storage/blob/_shared/avro/__init__.py
Show resolved
Hide resolved
**kwargs) | ||
except StorageErrorException as error: | ||
except HttpResponseError as error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there's been some updates to error handling - do any of out live tests deal with errors raised from Storage? It shouldn't be an issue, but would be nice to know we have coverage :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, we don't have tests covering storage errors as for most blob storage errors, our sdk simply bubble up or ignore them.
The only errors we care about are ResourceModifiedError, ResourceExistsError
which are treated as OwnershipLostError
:
Lines 163 to 173 in f0697ff
except (ResourceModifiedError, ResourceExistsError): | |
logger.info( | |
"EventProcessor instance %r of namespace %r eventhub %r consumer group %r " | |
"lost ownership to partition %r", | |
owner_id, | |
fully_qualified_namespace, | |
eventhub_name, | |
consumer_group, | |
partition_id, | |
) | |
raise OwnershipLostError() |
I don't think we need to cover all of the blob storage errors now based on our current "bubble up or ignore" approach. but I'm always open to adding new tests if needed :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions but generally looks good to me.
trying to resolve issues: #16192
use the storage-blob version v12.7.1: https://github.com/Azure/azure-sdk-for-python/tree/azure-storage-blob_12.7.1, commit id: e8edeb8