Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TrafficManager] Update #1597

Merged
merged 2 commits into from
Feb 22, 2018
Merged

[TrafficManager] Update #1597

merged 2 commits into from
Feb 22, 2018

Conversation

AutorestCI
Copy link
Contributor

Generated from RestAPI PR: Azure/azure-rest-api-specs#1920

@AutorestCI AutorestCI requested a review from lmazuel as a code owner November 2, 2017 17:58
@AutorestCI AutorestCI mentioned this pull request Nov 2, 2017
Merged
10 tasks
@lmazuel
Copy link
Member

lmazuel commented Nov 2, 2017

See too #1513

@lmazuel lmazuel mentioned this pull request Nov 2, 2017
Closed
@lmazuel lmazuel changed the title Automatic PR from RestAPI-PR1920 [TrafficManager] Update Nov 2, 2017
@codecov-io
Copy link

codecov-io commented Nov 2, 2017 •
edited
Loading

Codecov Report

Merging #1597 into master will decrease coverage by 0.02%.
The diff coverage is 42.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
- Coverage    54.7%   54.68%   -0.03%     
==========================================
  Files        3679     3686       +7     
  Lines       90929    91075     +146     
==========================================
+ Hits        49745    49804      +59     
- Misses      41184    41271      +87
Impacted Files Coverage Δ
...ger/models/traffic_manager_geographic_hierarchy.py 71.42% <ø> (ø) ⬆️
...nager/azure/mgmt/trafficmanager/models/endpoint.py 33.33% <ø> (ø) ⬆️
...manager/azure/mgmt/trafficmanager/models/region.py 57.14% <ø> (ø) ⬆️
.../azure/mgmt/trafficmanager/models/profile_paged.py 80% <ø> (ø) ⬆️
...anager/azure/mgmt/trafficmanager/models/profile.py 45.45% <ø> (ø) ⬆️
...ure/mgmt/trafficmanager/models/tracked_resource.py 62.5% <ø> (ø) ⬆️
...azure/mgmt/trafficmanager/models/monitor_config.py 36.36% <ø> (ø) ⬆️
...er/operations/geographic_hierarchies_operations.py 44.44% <100%> (ø) ⬆️
...t/trafficmanager/operations/profiles_operations.py 12.24% <100%> (ø) ⬆️
.../trafficmanager/operations/endpoints_operations.py 17.24% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead535c...9ebb675. Read the comment docs.

@hrkulkarMsft
Copy link
Member

Hi, are there any blockers to merge this?

@lmazuel
Copy link
Member

lmazuel commented Nov 7, 2017

@hrkulkarMsft time :)
I have no tests of the features, no feedback from the CLI on the content and no ask from them on it. Plus it's a preview API and I don't know what is the release story planned (when is GA planned? etc.)

@lmazuel
Copy link
Member

lmazuel commented Feb 22, 2018

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/trafficmanager/resource-manager/readme.md

@AutorestCI
Copy link
Contributor Author

Nothing to rebuild, this PR is up to date

@lmazuel
Copy link
Member

lmazuel commented Feb 22, 2018

@AutorestCI rebase

@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@lmazuel
Copy link
Member

lmazuel commented Feb 22, 2018

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/trafficmanager/resource-manager/readme.md

@AutorestCI
Copy link
Contributor Author

Build SDK finished and cleaned

@lmazuel lmazuel changed the base branch from master to restapi_auto_trafficmanager/resource-manager February 22, 2018 00:51
@lmazuel
Copy link
Member

lmazuel commented Feb 22, 2018

Merge into a TrafficManager feature branch

@lmazuel lmazuel merged commit 43788d2 into Azure:restapi_auto_trafficmanager/resource-manager Feb 22, 2018
@lmazuel lmazuel deleted the RestAPI-PR1920 branch February 22, 2018 00:51
AutorestCI added a commit that referenced this pull request Feb 28, 2018
@AutorestCI
[TrafficManager] Update (#1597)
a8d78f5 
* Generated from 342d0f9

* Rebuild by #1597
AutorestCI added a commit that referenced this pull request Mar 7, 2018
@AutorestCI
[TrafficManager] Update (#1597)
7370abc 
* Generated from 342d0f9

* Rebuild by #1597
lmazuel pushed a commit that referenced this pull request May 25, 2018
@AutorestCI @lmazuel
[TrafficManager] Update (#1597)
0372280 
* Generated from 342d0f9

* Rebuild by #1597
lmazuel added a commit that referenced this pull request May 25, 2018
@lmazuel
azure-mgmt-trafficmanager 0.50.0 (#2038)
a68d867 
* [TrafficManager] Update (#1597)

* Generated from 342d0f9

* Rebuild by #1597

* Generated from 522734738313c7d5b08453d1edc8427d89ce2810 (#2479)

Introduce Azure Traffic Manager 2018-03-01 API version with custom headers and status code ranges options.

* Generated from 0a167ffd54481f34ac2101552224462d416857f1 (#2564)

Adding 2018-02-01 Traffic Manager API version.

* Rebuild by #2038

* azure-mgmt-trafficmanager packaging

* azure-mgmt-trafficmanager 0.50.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
ARM Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AutorestCI @lmazuel @codecov-io @hrkulkarMsft