-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename async checkpoint samples README title #15958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swathipil
requested review from
annatisch and
KieranBrantnerMagee
as code owners
December 31, 2020 18:56
ghost
added
the
Event Hubs
label
Dec 31, 2020
rakshith91
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yunhaoling
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Jan 8, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jan 8, 2021
…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (85 commits) Update to Update-Changelog.ps1 (Azure#15981) Fix put_encrypted_blob function (Azure#15918) renamed checkpoint by batch samples to by event count (Azure#15977) Migration guide for EventGrid (Azure#15731) Clearer message for incomplete environment configuration (Azure#15974) renamed async checkpoint sample readme title (Azure#15958) fixed 'async with outside async func' syntax error in EH async auth with conn str sample (Azure#15955) fixed typo in EH sample + readme (Azure#15954) Clean up batch delete sample (Azure#15898) Add azure core to mgmt dependency (Azure#15969) [T2] GA rdbms (Azure#15934) GA commerce track2 sdk (Azure#15907) GA batch track2 sdk (Azure#15906) GA policyinsights track2 sdk (Azure#15905) GA search track2 sdk (Azure#15904) GA notificationhubs track2 sdk (Azure#15903) [T2] GA relay (Azure#15902) GA cognitiveservices track2 sdk (Azure#15901) GA advisor track2 sdk (Azure#15900) GA marketplaceordering track2 sdk (Azure#15899) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Oct 1, 2021
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 (Azure#15958) * Adds base for updating Microsoft.Consumption from version stable/2021-05-01 to version 2021-10-01 * Updates readme * Updates API version in new specs and examples * added benefitid and benefitname * adding descr for benefitid and benefitname * Deprecate Forecasts * added provider in modern * Adding description for the provider * 1) removed BenefitId and BenefitName from legacy 2) chnaged value of Publishertype fro 1pp to Microsoft 3) updated examples with ReservationName and BenefitId and BeneftName for modern * Make changes based on s360 * Fix example errors * Missed an instance of purchaseDate type * No schema for 204 * No schema for 204 * No schema for 204 * Ran prettier * Add changes to 10.01.21 * Ran prettier * Revert "Ran prettier" This reverts commit 1a0fbfe4a2b0583a3db0b4f985a5857925763958. * Revert "No schema for 204" This reverts commit 181f6c5af6add248619fbb558f59e7bb3820075d. * Revert "Missed an instance of purchaseDate type" This reverts commit d77898dcf5ec20620a84e5ec51bcb1b93df54d82. * Revert "Fix example errors" This reverts commit 06be042e08acb88232b46d80b77bdf4dad48dde1. * Revert "Make changes based on s360" This reverts commit 0960cc2078504e76328811f9eb9f5be1a25e1f2d. * Manually change 2021-05-01 * removing reservationName * costAllocationRule * Adding missing fields * Operation scopeReservationRecommendationDetails had two params with the same name scope, so fixing it. * chnaging the casing for eTag * chnaging the casing for eTag * reservation api * Arm feedback - add enum to PricingModel * pretty check * linter check * pretty check Co-authored-by: Mita Garg <[email protected]> Co-authored-by: Alex Goldschmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #15114
Updating title for async samples here: https://docs.microsoft.com/en-us/samples/azure/azure-sdk-for-python/eventhub-checkpointstore-aio-samples/