Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Add Swagger and examples for ManagedDatabases #1586

Closed
wants to merge 1 commit into from

Conversation

AutorestCI
Copy link
Contributor

Generated from RestAPI PR: Azure/azure-rest-api-specs#1812

@lmazuel lmazuel changed the title Automatic PR from RestAPI-PR1812 [SQL] Add Swagger and examples for ManagedDatabases Oct 30, 2017
@lmazuel lmazuel requested a review from jaredmoo October 30, 2017 20:41
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ManagedDatabases isn't in production yet, I am removing this from the readme in Azure/azure-rest-api-specs#1949

@codecov-io
Copy link

codecov-io commented Oct 30, 2017

Codecov Report

Merging #1586 into master will decrease coverage by 0.06%.
The diff coverage is 26.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
- Coverage   53.82%   53.76%   -0.07%     
==========================================
  Files        3675     3680       +5     
  Lines       90911    91122     +211     
==========================================
+ Hits        48932    48988      +56     
- Misses      41979    42134     +155
Impacted Files Coverage Δ
azure-mgmt-sql/azure/mgmt/sql/models/__init__.py 100% <100%> (ø) ⬆️
...e-mgmt-sql/azure/mgmt/sql/sql_management_client.py 100% <100%> (ø) ⬆️
...ure/mgmt/sql/models/sql_management_client_enums.py 100% <100%> (ø) ⬆️
...ure-mgmt-sql/azure/mgmt/sql/operations/__init__.py 100% <100%> (ø) ⬆️
...gmt/sql/operations/managed_databases_operations.py 11.48% <11.48%> (ø)
...mgmt-sql/azure/mgmt/sql/models/managed_database.py 31.25% <31.25%> (ø)
...l/azure/mgmt/sql/models/managed_database_update.py 31.25% <31.25%> (ø)
...ql/azure/mgmt/sql/models/managed_database_paged.py 80% <80%> (ø)
...ls/complete_managed_database_restore_definition.py 83.33% <83.33%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa626b1...4d2a02f. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Oct 30, 2017

Close, since not in production yet.

@lmazuel lmazuel closed this Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants