Add Changelog Verification to Python #15274
Conversation
chidozieononiwu
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
chidozieononiwu
force-pushed
the
feature/HookUpChangeLogVerification
branch
from
f02f424 to
792e777
Compare
eng/scripts/Language-Settings.ps1
Outdated
| @@ -4,6 +4,8 @@ $packagePattern = "*.zip" | |||
| $MetadataUri = "https://raw.githubusercontent.com/Azure/azure-sdk/master/_data/releases/latest/python-packages.csv" | |||
| $BlobStorageUrl = "https://azuresdkdocs.blob.core.windows.net/%24web?restype=container&comp=list&prefix=python%2F&delimiter=%2F" | |||
|
|
|||
| $SkipChangeLogVerification.Add("azure-data-nspkg", $true) | |||
There was a problem hiding this comment.
Why can't we add a changelog and fix it here instead of trying to skip it?
There was a problem hiding this comment.
That's what I initially set out to do but @scbedd says there is a reason it has no version/ changelog file.
There was a problem hiding this comment.
@weshaggard nspkgs are published exactly once. There is very little functional reason to maintain a changelog for it.
There was a problem hiding this comment.
I will note that the way that that Dozie implemented it can be skipped individually on the artifact basis. That'll definitely work for this purpose.
chidozieononiwu
force-pushed
the
feature/HookUpChangeLogVerification
branch
from
792e777 to
b1ae126
Compare
| - task: PythonScript@0 | ||
| displayName: 'Verify Change Log' | ||
| inputs: | ||
| scriptPath: 'scripts/devops_tasks/verify_change_log.py' |
There was a problem hiding this comment.
Is it time to also remove the verify_change_log.py script?
There was a problem hiding this comment.
|
Looks like this may have broken the release pipelines: |
For some reason it fails to retrieve the package properties |
Time Series Insights - add 2021-06-30-preview API version, and supportsCustomerManagedKey output property (Azure#15274) * Adds base for updating Microsoft.TimeSeriesInsights from version stable/2020-05-15 to version 2021-06-30-preview * Updates readme * Updates API version in new specs and examples * Add supportsCustomerManagedKey to env response definition, examples
This add changelog verification to the analyze and release stages of the python pipeline.
Fixes #12566