-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[form recognizer] add tests for invoice multipage #15012
Merged
iscai-msft
merged 2 commits into
Azure:feature/formrecognizer2.1
from
iscai-msft:invoice_multipage_2
Nov 5, 2020
Merged
[form recognizer] add tests for invoice multipage #15012
iscai-msft
merged 2 commits into
Azure:feature/formrecognizer2.1
from
iscai-msft:invoice_multipage_2
Nov 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
willmtemple,
maririos,
samvaity,
kristapratico and
mssfang
November 4, 2020 21:43
ghost
added
the
Cognitive - Form Recognizer
label
Nov 4, 2020
|
||
self.assertInvoiceTransformCorrect(returned_model, document_result.fields, read_results) | ||
|
||
self.assertFormPagesTransformCorrect(returned_model.pages, read_results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
self.assertFormPagesTransformCorrect(returned_model.pages, read_results) | |
self.assertFormPagesTransformCorrect(returned_model.pages, read_results, page_results) |
We should pass in the page_results here so we can check the table transform
maririos
approved these changes
Nov 5, 2020
kristapratico
approved these changes
Nov 5, 2020
kristapratico
added a commit
that referenced
this pull request
Nov 23, 2020
* [formrecognizer] 2.1-preview.2 gen and impl (#14929) * regen * add invoice impl * regen with image/bmp content type for all analyze methods * support word appearance (gen code only) * support page_range kwonly arg on content API * add bounding_box to FormTable * fix spacing * add invoice tests * add invoice samples * revert erroneous search commit * add docstring samples for business cards and invoices * add aka link for fields to business card and invoice samples * add invoice to readme * add support for image/bmp * regen with new changes and hook up gen code * update changelog * add tests for content - specify pages * regen with text appearance on line instead of word * add appearance to exposed model for FormLine * update testcase * fix and add table bounding box check to testcase * skip receipt/business cards tests until features deployed; uncomment some tests where bugs were fixed * don't record large request bodies * fixes to tests/testcase * more updates to tests * update logging tests * update content samples * moving recordings to another PR * fix pylint * fix * let invoices return tables * pylint fix * update readme examples to include invoice for now * update content_type docstring description * update grammar * adding v2.1 recordings (receipt/business card skipped for now) (#14928) * rerecord an invoice test Co-authored-by: iscai-msft <[email protected]> * [formrecognizer] add copy tests for new features in v2.1 (#14987) * add copy tests for new features in v2.1 * rerecord test * test that submodels are the same and fix get custom model for composed model * [formrecognizer] adds language param (#14984) * regen latest swagger in PR * add language to form recognizer clients and update changelog * add basic tests for language * update docstrings * newlines * docstring feedback * update language docstring to point to service docs for available language codes * [form recognizer] add tests for invoice multipage (#15012) * [formrecognizer] fix sphinx errors and unify transform testcase for FormFields (#15056) * fix sphinx errors * unify method for checking transform of FormFields and update tests * switch invoices test to use unified form fields transform check * accidental whitespace * [formrecognizer] allow None for required params when passing a continuation_token into an LRO method (#15010) * update clients such that when using a continuation token, you can pass None for any required params in method * update continuation token tests * receipt test - total value fixed (#15159) * add python 3.9 to setup classifiers (#15208) * [formrecognizer] adds tests for forms in other languages (#15173) * adding language option to testcase to get blob url of form * add sync tests * add async tests * add async recordings * fix testcase for recordings * [formrecognizer] unskip receipt/business card tests and re-record with preview.2 (#15270) * rerecord business card and receipt tests with preview.2 * preface commented out test assertions with FIXME * [formrecognizer] Remove business card ContactNames page_number workaround (#15275) * revert setting business card ContactNames page number now that service returns this value * remove workaround in tests * uncomment receipt test assertions - regression fixed (#15345) * [formrecognizer] doc updates (#15346) * docs fixes, wip * more docs updates * more doc updates * [formrecognizer] try using existing resource in live tests (#15483) * try using existing FR resource * rename * fix env var name (#15486) * [formrecognizer] updates to test in prod (#15491) * add python 3.9 to live tests matrix * sleep for 10 mins between resource creating and calls to endpoints * receipt regression not fixed in prod yet - comment assertions out * update timeout for live runs for FR (#15492) * remove sample tests - will be run in smoke tests (#15494) Co-authored-by: iscai-msft <[email protected]> Co-authored-by: iscai-msft <[email protected]>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Jun 29, 2021
Update SecurityInsights metadata preview API (Azure#15012) * Copy commit from private repo * Make new API version * Remove old examples * Fix exclusion for Metadata list endpoint * Move back to initial preview version * Change id to contentId, sourceId * Fix sourceId in get all example * Update enums, required fields * Update enums, required fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14402