BREAKING CHANGE: Adl object refactor #1324
Conversation
* Found two bugs that I needed to fix in order to run tests in Playback mode: * including vcrpy in requirements.txt * resource-manager to data-plane in swagger_to_sdk_config.json for catalog.json and job.json
|
@ro-joowan, |
|
@lmazuel here is the aggregated PR for python that I promised you :). I reviewed this with @ro-joowan and helped him get it done. For some reason the automatic PR passed while this one required some test updates, so I am glad that we did it this way and caught the test failures :). |
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
+ Coverage 56.14% 56.19% +0.04%
==========================================
Files 2719 2728 +9
Lines 71614 71708 +94
==========================================
+ Hits 40205 40293 +88
- Misses 31409 31415 +6
Continue to review full report at Codecov.
|
.gitignore
Outdated
| @@ -4,6 +4,7 @@ __pycache__/ | |||
|
|
|||
| # Virtual environment | |||
| env*/ | |||
| myEnv/ | |||
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| Release History | |||
| =============== | |||
| 0.2.0 (2017-07-25) | |||
| ++++++++++++++++++ | |||
| * Create an inheritance structure for GET and LIST ADLS accounts. | |||
There was a problem hiding this comment.
ChangeLog should be customer focus: what is the actual difference for my code. If you change 90% of the code, but it's changing nothing, I don't want a ChangeLog. Opposite, if you change only a comma, but it's breaking I want why.
Then, the current bullet list is more a tasks list than a ChangeLog :)
requirements.txt
Outdated
| @@ -2,3 +2,4 @@ futures;python_version<="2.7" | |||
| python-dateutil | |||
| pyopenssl | |||
| msrestazure>=0.4.0,<0.5.0 | |||
| vcrpy | |||
There was a problem hiding this comment.
Remove that, vcrpy is installed by the test requirements file (see .travis.yaml)
azure.pyproj
Outdated
| @@ -2885,6 +2884,17 @@ | |||
| <Content Include="setup.cfg" /> | |||
| <Content Include="swagger_to_sdk_config.json" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
There was a problem hiding this comment.
I don't want this file in the PR, this is not supposed to be checked in
| * related | ||
| * Create a "Basic" jobInformation that is returned for LIST calls | ||
| * Setup inheritance for GET jobs | ||
| * Create an inheritance structure for GET and LIST ADLA accounts. |
There was a problem hiding this comment.
See comments on the other ChangeLog
These fixes are related to this PR: Azure#1324
# Conflicts: # azure-mgmt-datalake-analytics/HISTORY.rst
|
Approved based on the comments I made. Up to you to tell me when it's ready to be release :) Thanks! |
Adding a couple of important notes on Job and Account retrieval
Adding an important note about Account retrieval
|
Please merge and publish! Thank you, |
This PR is mapped to this Swagger change: Azure/azure-rest-api-specs#1429
Revised the inheritance structure and broke up objects for customer-experience clarity
For more details, please refer to the PR above
Found two bugs that I needed to fix in order to run tests in Playback mode:
There were also a couple modifications that I made to azure-mgmt/tests/test_mgmt_datalake_analytics.py in order for the tests to pass. However, all the tests in the automatic PR passed, which was odd.