Restructure ChangeLogLogic #12769
Closed
Restructure ChangeLogLogic #12769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
chidozieononiwu
force-pushed
the
RestructureCommonTools
branch
from
82d3d0d to
83cfe7d
Compare
weshaggard
reviewed
Jul 28, 2020
chidozieononiwu
force-pushed
the
RestructureCommonTools
branch
from
83cfe7d to
5801f59
Compare
weshaggard
reviewed
Jul 28, 2020
chidozieononiwu
force-pushed
the
RestructureCommonTools
branch
7 times, most recently
from
0ec85a9 to
95c6bc8
Compare
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
reviewed
Aug 10, 2020
| @@ -28,6 +28,14 @@ stages: | |||
| deploy: | |||
| steps: | |||
| - checkout: self | |||
| - script: | | |||
There was a problem hiding this comment.
What in our verify-changelog requires the ci_tools to be pip installed first?
There was a problem hiding this comment.
That's not needed since we are no longer using the previous changelog verification. @praveenkuttappan is there any other why you added this.
chidozieononiwu
force-pushed
the
RestructureCommonTools
branch
from
add1508 to
7353877
Compare
chidozieononiwu
force-pushed
the
RestructureCommonTools
branch
from
7353877 to
9f4bbb0
Compare
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 2, 2021
Revert "[DataFactory]Set servicePrincipalId,servicePrincipalKey and tenant to be optional from AzureDataExplorerLinkedServiceTypeProperties (Azure#12755)" (Azure#12769) This reverts commit baa5ac2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure changelog logic to remove reliance on modules and make use of
eng\common\scripts\common.ps1Add Changelog to analyze job as well as release stage to resolve issues raised here