Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backward Incompatibility of azure-ai-ml 1.9.0 #31319

Closed
trajepl opened this issue Jul 26, 2023 · 5 comments · Fixed by #31469
Closed

Backward Incompatibility of azure-ai-ml 1.9.0 #31319

trajepl opened this issue Jul 26, 2023 · 5 comments · Fixed by #31469
Assignees
@luigiw
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@trajepl
Copy link

trajepl commented Jul 26, 2023 •
edited
Loading

  • Package Name: azure-ai-ml
  • Package Version: 1.9.0
  • Operating System: Unix
  • Python Version: python3.8

Describe the bug
A clear and concise description of what the bug is.
azure-ai-ml (=1.9.0) can not accept Pathlib for command code .

But when 1.9.0 was released, the following change will never allow PathLike arguments which is incompatibility with the version less than 1.9.0. Also the returning is kept as str, os.PathLike still. Not sure the typing checking is by design or not. Please help double check.

(BTW, it is not blocking our codes. We can always cast PathLike to str before assignment. Just raise it up in case there are anything missed)

image

https://github.com/Azure/azure-sdk-for-python/blob/1356c85959f4ba182a92491f6d99d016411c8ab1/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_component/command_component.py#L142C1-L149C1

To Reproduce
Steps to reproduce the behavior:
1.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 26, 2023
@trajepl trajepl changed the title Incompatibility of azure-ai-ml 1.9.0 Backward Incompatibility of azure-ai-ml 1.9.0 Jul 26, 2023
@trajepl trajepl mentioned this issue Jul 26, 2023
Merged
5 tasks
trajepl added a commit to microsoft/Olive that referenced this issue Jul 26, 2023
@trajepl
⛏️ Unpin aml sdk version (#442)
0379786 
## Describe your changes

Unpin aml sdk version.
Related issue:
Azure/azure-sdk-for-python#31319

## Checklist before requesting a review
- [ ] Add unit tests for this change.
- [ ] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [ ] Format your code by running `pre-commit run --all-files`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.

## (Optional) Issue link
@kashifkhan
Copy link
Member

Thank you for the feedback @trajepl . We will investigate and get back to you asap.

cc @azureml-github

@kashifkhan kashifkhan added Service Attention Workflow: This issue is responsible by Azure service team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jul 26, 2023
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jul 26, 2023
@github-actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureml-github @Azure/azure-ml-sdk.

@diondrapeck
Copy link
Member

diondrapeck commented Jul 26, 2023 •
edited
Loading

Hi @trajepl, We'll fix this in an upcoming PR. Thank you for bringing it to our attention.

@diondrapeck
Copy link
Member

@elliotzh - could you please address the backcompat issue introduced in this PR: 1356c85?

image

@elliotzh
Copy link
Contributor

Thanks for the report! @trajepl Yes this type check is not by-design and should also accept os.PathLike, will fix it ASAP.

@elliotzh elliotzh mentioned this issue Aug 4, 2023
Merged
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luigiw luigiw

Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML][Pipelines] fix: accept PathLike as code of CommandComponent elliotzh/azure-sdk-for-python
5 participants
@kashifkhan @luigiw @trajepl @diondrapeck @elliotzh