Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-monitor-opentelemetry-exporter not compatible with latest opentelemetry-[api/sdk] 1.15.0 #27900

Closed
jabbera opened this issue Dec 10, 2022 · 6 comments · Fixed by #27958
Closed
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@jabbera
Copy link
Contributor

jabbera commented Dec 10, 2022

  • Package Name: azure-monitor-opentelemetry-exporter
  • Package Version: 1.0.0b10
  • Operating System: Linux
  • Python Version: 3.10

Describe the bug
not compatible with opentelemetry-[api/sdk] 1.15.0

To Reproduce
Steps to reproduce the behavior:

  1. pip install azure-monitor-opentelemetry-exporter
  2. python3.10
  3. from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter, AzureMonitorTraceExporter

see:

.tox/py310-sqlalchemy14-integration/lib/python3.10/site-packages/gmo/core/util/telemetry/__init__.py:8: in <module>
    from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter, AzureMonitorTraceExporter
.tox/py310-sqlalchemy14-integration/lib/python3.10/site-packages/azure/monitor/opentelemetry/exporter/__init__.py:7: in <module>
    from azure.monitor.opentelemetry.exporter.export.logs._exporter import AzureMonitorLogExporter
.tox/py310-sqlalchemy14-integration/lib/python3.10/site-packages/azure/monitor/opentelemetry/exporter/export/logs/_exporter.py:8: in <module>
    from opentelemetry.sdk._logs.severity import SeverityNumber
E   ModuleNotFoundError: No module named 'opentelemetry.sdk._logs.severity'

Expected behavior
import to work

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 10, 2022
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2022
@kashifkhan
Copy link
Member

Thank you for your feedback @jabbera . We will investigate asap and get back to you

@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Thank you for your feedback. This has been routed to the support team for assistance.

@kashifkhan kashifkhan added the Monitor - Exporter Monitor OpenTelemetry Exporter label Dec 12, 2022
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Dec 12, 2022
@jeremydvoss
Copy link
Member

The PR is merged. However, since this is an ongoing issue, let's keep this open until the next release. I am looking into whether we can do a release before January. In the meantime, use OTel 1.14

@jeremydvoss
Copy link
Member

There's another issue: when using the fixed version of the exporter with OTel 1.15, I consistently get the following warning:
...\site-packages\werkzeug\serving.py:716: ResourceWarning: unclosed <socket.socket fd=1304, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0> self.socket = socket.fromfd(fd, address_family, socket.SOCK_STREAM) ResourceWarning: Enable tracemalloc to get the object allocation traceback

I've determined that no commit in exporter 1.0.0b11 has caused this. It's too early to know. But it seems to be an issue with how opentelemetry-instrumentation-flask==0.36b0 or opentelemetry-instrumentation-wsgi==0.36b0 use Werkzeug. I've confirmed the fixed version of the exporter does still send telemetry correctly. However, since the new version needs to be pinned to 1.15, we'll be encouraging people to use 1.15 seems to have some issue that needs to be addressed.

I am not able to release the exporter as is because of the memory issue with OTel 1.15. Instead, we can pin the exporter to 1.12<=x<=1.14 before the module path was changed. That way, we can avoid the memory allocation issue as well as the severity import breaking change.

@jeremydvoss
Copy link
Member

My release PR is approved. But my understanding is others have the exclusive permissions to merge it and trigger the release pipeline.
#27958

@jeremydvoss
Copy link
Member

@jabbera Please use newly released 1.0.0b11. It blocks OTel 1.15. Resolving issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
4 participants