Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Consider renaming test files #22025

Closed
3 tasks done
catalinaperalta opened this issue Dec 6, 2021 · 0 comments · Fixed by #22396
Closed
3 tasks done

[formrecognizer] Consider renaming test files #22025

catalinaperalta opened this issue Dec 6, 2021 · 0 comments · Fixed by #22396
Assignees
@catalinaperalta
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer

Comments

@catalinaperalta
Copy link
Member

catalinaperalta commented Dec 6, 2021 •
edited
Loading

  • Consider renaming test files to more clearly show what client they are testing. For example:
    • test_document.py -> test_dac_prebuilt_document.py
    • test_business_card.py -> test_frc_business_card.py
  • Consider renaming GlobalClientPreparer in v2.1 tests to FormRecognizerClientPreparer to have more symmetry with DAC test preparer.
  • Consider how to consolidate v2.1 tests into less files.
@catalinaperalta catalinaperalta self-assigned this Dec 6, 2021
This was referenced Dec 6, 2021
Merged
Merged
@lmazuel lmazuel added the Client This issue points to a problem in the data-plane of the library. label Dec 17, 2021
@catalinaperalta catalinaperalta mentioned this issue Jan 8, 2022
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Feb 28, 2023
@mozansaka
CodeGen from PR 22124 in Azure/azure-rest-api-specs
fbd30b3 
[Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version stable/2022-11-08 (Azure#22124)

* Adds base for updating Microsoft.DBforPostgreSQL from version preview/2020-10-05-privatepreview to version 2022-11-08

* Updates readme

* Updates API version in new specs and examples

* empty commit (Azure#21932)

Co-authored-by: Ozan Saka <[email protected]>

* 2022 11 08 (Azure#22025)

* Add private endpoint con. and private link endpoints

* Add private link list example

* Cluster related endpoint and exampled changes

* Cluster changes and configuration updates

* Long running operation header additions

* Change server group to cluster

* Add systemData to examples, fix private endpoint con. property

* Fix private link resource name parameter

* Fix INVALID_TYPE boolean given as strings

* Update approve private endp. con. request body

* Fix OBJECT_ADDITIONAL_PROPERTIES and READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST

* Fix INVALID_TYPE

* Fix ModelValidation Errors

* Fix lint errors

* Fix lint errors

* Remove location from cluster examples

* Update example details, fix common types

* Update readme files, fix configuration example name

* Fix SDK generation by removing wrong pageable tags

* Update configuration response types, fix cluster name pattern

* Update configuration example names

* Readme changes and minor final state via fix

* Fix indentation on suppression items

* Update node count description, remove pec id

* Update cluster examples

* Style fix

* Update description

Co-authored-by: Ozan Saka <[email protected]>
Co-authored-by: Sena Gungor <[email protected]>

* Fix credscan password (Azure#22127)

Co-authored-by: Ozan Saka <[email protected]>

* Add required parameters (Azure#22244)

* Add 200 resp. code to put&patch, change boolean to enum (Azure#22290)

* Add 200 resp. code to put&patch, change boolean to enum

* Update 200 responses

* Update 200 response schemas, enum casing

* Update configuration put requests

* Remove role no-op case

* fix private endp con list error, remove 200 code from role example

* Add coord/node config list endpoints

* fix sdk errors

* add 200 resp for configuration put requests

* Update readme

* Fix arm feedbacks (Azure#22334)

* Fix arm feedbacks

* Add pointInTimeUTC

* Update passwords and readme file

* Update response codes to 201, address feedbacks (Azure#22386)

* Update response codes to 201

* Add server configuration get

* Update password

* Fix duplicate operation id

* Update configuration example files

* Update configuration example files

* Fix credscan issue (Azure#22389)

* Fix PutRequestResponseScheme error (Azure#22408)

* Fix PutRequestResponseScheme error

* Update readme file

* Update x-ms-mutability

* Update property description

* Fix server properties (Azure#22772)

* Fix server properties

---------

Co-authored-by: mozansaka <[email protected]>
Co-authored-by: Ozan Saka <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@catalinaperalta catalinaperalta

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[formrecognizer] Rename test files catalinaperalta/azure-sdk-for-python
2 participants
@lmazuel @catalinaperalta