Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace.get method unintentionally exposes subscription id when Workspace is not found. #19563

Closed
Bhanurdra opened this issue Jun 29, 2021 · 3 comments
Assignees
Labels
ADO Issue is documented on MSFT ADO for internal tracking customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning ML-CoreUI AreaPath question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@Bhanurdra
Copy link

Bhanurdra commented Jun 29, 2021

Package Name & Version:
azureml-core==1.31.0
Operating System: Windows
Python Version: 3.8.0

Describe the bug
The get_workspace method under _commands.py module exposes the users' subscription id when the user tries to validate whether the particular ML Workspace exists under the given resource or not.
This issue is reproducible in Github Action as well.

To Reproduce
Steps to reproduce the behavior:

  1. Create an account in https://portal.azure.com/
  2. Create only a resource group in Azure .
  3. Run following to get the Service Principal details: az ad sp create-for-rbac --name {name} --role contributor --scopes /subscriptions/{subscription id}/resourceGroups/test --sdk-auth
  4. Run the following code to check whether the ML Workspace exists under the resource group created in step 2
from azureml.core import Workspace
from azureml.core.authentication import ServicePrincipalAuthentication
from azureml.exceptions import ProjectSystemException

auth = ServicePrincipalAuthentication(tenant_id="3XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
                                      service_principal_id="9XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
                                      service_principal_password="XXX_XXXXXXXXXXXXXX_XXXXX~XX~XXXXXX",
                                      cloud='AzureCloud')
try:
    work_space = Workspace.get(auth=auth,
                               subscription_id="3XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
                               resource_group="test",
                               name="test-github",
                               location="eastus2",
                               cloud="AzureCloud")
except ProjectSystemException as exception:
    print(f"Error: {exception}")

Expected behavior
I have created resource group named "test".
Since ML Workspace isn't created using above mentioned steps, it is expected to be throwing ProjectSystemException error alone.

Actual behavior
It throws ProjectSystemException error along with get_workspace method error exposing the subscription id. Please refer the screenshot below.

Screenshots
From local system

image

From Github Action Log

image

Let me know if any additional details are required from my end.

Thanks
Bhanu

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 29, 2021
@kristapratico kristapratico added ML-CoreUI AreaPath Service Attention Workflow: This issue is responsible by Azure service team. Machine Learning and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jul 6, 2021
@ghost
Copy link

ghost commented Jul 6, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureml-github.

Issue Details

Package Name & Version:
azureml-core==1.31.0
Operating System: Windows
Python Version: 3.8.0

Describe the bug
The get_workspace method under _commands.py module exposes the users' subscription id when the user tries to validate whether the particular ML Workspace exists under the given resource or not.
This issue is reproducible in Github Action as well.

To Reproduce
Steps to reproduce the behavior:

  1. Create an account in https://portal.azure.com/
  2. Create only a resource group in Azure .
  3. Run following to get the Service Principal details: az ad sp create-for-rbac --name {name} --role contributor --scopes /subscriptions/{subscription id}/resourceGroups/test --sdk-auth
  4. Run the following code to check whether the ML Workspace exists under the resource group created in step 2
from azureml.core import Workspace
from azureml.core.authentication import ServicePrincipalAuthentication
from azureml.exceptions import ProjectSystemException

auth = ServicePrincipalAuthentication(tenant_id="3XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
                                      service_principal_id="9XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
                                      service_principal_password="XXX_XXXXXXXXXXXXXX_XXXXX~XX~XXXXXX",
                                      cloud='AzureCloud')
try:
    work_space = Workspace.get(auth=auth,
                               subscription_id="3XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
                               resource_group="test",
                               name="test-github",
                               location="eastus2",
                               cloud="AzureCloud")
except ProjectSystemException as exception:
    print(f"Error: {exception}")

Expected behavior
I have created resource group named "test".
Since ML Workspace isn't created using above mentioned steps, it is expected to be throwing ProjectSystemException error alone.

Actual behavior
It throws ProjectSystemException error along with get_workspace method error exposing the subscription id. Please refer the screenshot below.

Screenshots
From local system

image

From Github Action Log

image

Let me know if any additional details are required from my end.

Thanks
Bhanu

Author: Bhanurdra
Assignees: -
Labels:

ML-CoreUI, Machine Learning, Service Attention, customer-reported, question

Milestone: -

@v-strudm-msft v-strudm-msft added the ADO Issue is documented on MSFT ADO for internal tracking label Jul 6, 2021
@Karishma-Tiwari-MSFT
Copy link

@v-strudm-msft Is this issue being addressed? Thanks.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Jun 24, 2022
Web ant97 2022 03 01 (Azure#19430)

* Adds base for updating Microsoft.Web from version stable/2021-03-01 to version 2022-03-01

* Updates readme

* Updates API version in new specs and examples

* Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegis… (Azure#18460)

* Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs to Api-version 2022-03-01

* Add x-ms-enum for array of inline enums. Fix reference to older api version for common defs

* Add examples for App Service Certificate orders

* Add suppressions back

* Add examples for Microsoft.DomainRegistration RP

* Fixes from prettier

* Remove unused example

* Add Unhealthy CustomDomainStatus for StaticSites (Azure#18557)

* Adding VnetRouteAllEnabled, VnetImagePullEnabled, VnetContentShareEnabled site properties to CommonDefinitions (Azure#18627)

* Added vnet realted site properties to common definitions

* removed tab

Co-authored-by: Tanay Bhartia <[email protected]>

* Add Ftp/Remote debug properties to Ase network config (Azure#18549)

* Add Ftp/Remote debug properties to Ase network config

* Switched changes to the right file

* Add Networking config to hosting environment creates

* Added some of the missing examples

* Remove disallowed properties from example Ase GET response

* Adjusted responses from other gets

* Added a bunch more examples

* Added other missing examples for Ase.

* Added more missing examples for Ase.

* fixed formatting

* Edit some examples, add back privatelink apis and try to supress the errors for missing examples.

* Fix suppress spelling and fix prettier

* Added missing privatelink examples since suppressing did not work

* Add Bring your own Backend operations (Azure#18517)

* add bring your own backend operations

* add missing files

* fix json formattin

* validation fixes

* fix

* fix more validation

* fix ids

* fix model validation

* fix descriptions

* fix environmentName description

* change to 202

* revert change to 202

* customhostnamesites optional param for 2022 API version (Azure#18670)

* fix DUPLICATE_PARAMETER

* prettier

* fix  OBJECT_ADDITIONAL_PROPERTIES

* fix random sub in examples

* add optional hostname param to customHostnameSites RT and add examples

* move changes from 2021 api version to 2022

* move examples to 2022

* Revert "add optional hostname param to customHostnameSites RT and add examples"

This reverts commit 7fc318e190de2108222dbb869d9a6219a02cae2f.

* remove examples from 2021

* fix lintDiff

* prettier fix

* model validation fix

* suppress model validation in readme

Co-authored-by: Elle Tojaroon <[email protected]>

* [Microsoft.Web] Add CustomDnsSuffixConfiguration to ASE (Azure#18553)

* [Microsoft.Web] Add CustomDnsSuffixConfiguration to AppServiceEnvironments

* Add examples

* Fix style issues

* Add customdnssuffix to custom-words

* Add CustomDnsSuffixConfiguration to AppServiceEnvironment definition

* Address remaining model validation errors

* Adjusted networking configuration definitions

* Addressed Arm review feedback

Co-authored-by: Jarod Aerts <[email protected]>

* Fork/web ant97 2022 03 01 (Azure#19259)

* Added DeploymentStatus API specs and examples

* change status to enum, rm extra dot

* suppress missing examples for now

* rm id from List Deployment Slot examples

* rm location, and rename deploymentId in GetSiteDeploymentStatus examples

* change model as string to true, add 202 operations for DeploymentStatus ops to spec

* rename operationId to deploymentStatusId, undo deploymentId rename

* add long running op, as per linter

Co-authored-by: Shubham Dhond <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>

* PublicNetworkAccess Swagger Change (Azure#19352)

* add publicNetworkAccess property in site for swagger

* add suppression to fix Model Validation CI

* Add allowed values in the description

* Add specs for Hosting Environment Maintenance Control (Azure#18691)

* Add documentation for Hosting Environment Maintenance Control

* Update example file name

* Make UpgradePreference non-nullable

* Correct indentation to 2 spaces

* Fix upgradePreference indentation

* Address swagger feedback. Add enums with descriptions.

* Move testNotification to request body. Update description text

* Fix testNotification

* Fix example

* Replace TestNotification parameter with TestUpgradeNotification API

* Rename to TestUpgradeAvailableNotification

* Added logic apps operations (Azure#18604)

* Added Initial Operations and some definitions

* Adding additional objects to support Logic Apps operations

* Updated path and parameters to match testing

* Prettier Fixes

* oav validat-example fixes

* Github validation fixes

* Prettier

* Updated examples and paths

* Prettier

* Revert "Prettier"

This reverts commit da090adf8005e0bd6fdc2ddebbd4390e5c4b6b20.

* Prettier

* Fixed model validation errors

* Filled in nextLinkName values

* Fixing swagger lintdiff errors

* added x-ms-long-running to async calls

* Adds numberOfWorkers to app service plan (Azure#19475)

* Adds numberOfWorkers to app service plan

* Add suppression for missing ASP examples

* Updating to fix workflow errors (Azure#19490)

* Removed conflicting resource definition and added reference to CommonDefinitions.json (Azure#19507)

* Removed conflicting resource definition and added reference to CommonDefinitions.json

* Updated resource to have workflow version

* Updated nextLink object to be correctly tagged (Azure#19560)

* Updated nextLink object to be correctly tagged

* Adding value placeholder

* Updated SKU to remove conflict

* Updated x-ms-enum

* Added missing model

* Adding more missing models

* Add suppressions for missing examples (Azure#19563)

Co-authored-by: Joseph Lin <[email protected]>
Co-authored-by: Tanay Bhartia <[email protected]>
Co-authored-by: Tanay Bhartia <[email protected]>
Co-authored-by: JarodAertsMs <[email protected]>
Co-authored-by: annikel <[email protected]>
Co-authored-by: Paviya (Elle) Tojaroon <[email protected]>
Co-authored-by: Elle Tojaroon <[email protected]>
Co-authored-by: Chris Chen <[email protected]>
Co-authored-by: Jarod Aerts <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Shubham Dhond <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: jiansong-msft <[email protected]>
Co-authored-by: Derek Johnson <[email protected]>
Co-authored-by: Alex Karcher <[email protected]>
@luigiw
Copy link
Contributor

luigiw commented Oct 20, 2022

Closing legacy issue.

Please consider upgrading to AzureML v2 CLI/SDK. https://learn.microsoft.com/en-us/azure/machine-learning/concept-v2

@luigiw luigiw closed this as completed Oct 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ADO Issue is documented on MSFT ADO for internal tracking customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning ML-CoreUI AreaPath question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

6 participants