Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python hard-coded master branch #17978

Closed
9 tasks done
sima-zhu opened this issue Apr 12, 2021 · 8 comments
Closed
9 tasks done

Fix Python hard-coded master branch #17978

sima-zhu opened this issue Apr 12, 2021 · 8 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 12, 2021
@sima-zhu sima-zhu added the EngSys This issue is impacting the engineering system. label Apr 12, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 12, 2021
@sima-zhu sima-zhu added the Central-EngSys This issue is owned by the Engineering System team. label Apr 12, 2021
@kurtzeborn
Copy link
Member

Ideally we can change this to use the default branch rather than hard coding "master" or "main".

@kurtzeborn kurtzeborn added Client This issue points to a problem in the data-plane of the library. and removed Central-EngSys This issue is owned by the Engineering System team. labels Apr 12, 2021
@lmazuel
Copy link
Member

lmazuel commented Apr 16, 2021

@sima-zhu :

  • I need some time for SwaggerToSdk, but you should not consider this a blocker, this tool is supposed to not be used anymore (though I use it sometime)
  • auto-release is not owned by our team CC @msyyc
  • test regression, you need to talk to @scbedd
  • ACR mgmt test, you need to talk to mgmt team
  • Identity I created an issue for @chlowell Dockerfile should not mention "master" explicitly #18113
  • "master" used as part of Swagger, can't do anything about it (Synapse, SQL, etc.)
  • "The txt files under test recording" I have no idea what you mean :p

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Apr 19, 2021

@lmazuel Thanks for driving the efforts!

"The txt files under test recording" I have no idea what you mean

I forgot to paste the link:
https://github.com/Azure/azure-sdk-for-python/tree/master/tools/azure-devtools/src/azure_devtools/ci_tools/tests/ReplayData

@scbedd scbedd self-assigned this Jun 17, 2021
@scbedd scbedd removed their assignment Jun 28, 2021
@scbedd
Copy link
Member

scbedd commented Jun 28, 2021

@lmazuel Are you ok with me updating swaggerToSDK to point at main? I scanned through the code. It SEEMS like we're safe to update it to main, as it's just used as the base branch when we're creating the swagger branch. However, I can't see any invocation of it, so I don't know if it's being aimed at the SDK repo or the AutoRest repo. If it's aimed at the autorest repo then this change is unnecessary and we can close this issue as completed IMO.

@lmazuel
Copy link
Member

lmazuel commented Aug 2, 2021

@scbedd sure, I guess it's fair now

@scbedd scbedd self-assigned this Oct 19, 2021
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Oct 19, 2021
@scbedd
Copy link
Member

scbedd commented Oct 19, 2021

azure-rest-api-specs defaults to main now, so I'm confident in the change in this PR.

@sima-zhu
Copy link
Contributor Author

@lmazuel @scbedd Could you confirm if the issue has addressed? I will go ahead close the issue if it is done.

@scbedd
Copy link
Member

scbedd commented Oct 22, 2021

Done! Closing.

@scbedd scbedd closed this as completed Oct 22, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Feb 24, 2022
copy from azure-rest-api-specs-pr/RPSaaSMaster (Azure#17978)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

4 participants