Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Microsoft.ServiceBus/namespaces/topics in azure.mgmt.monitor #17545

Closed
eladmotola opened this issue Mar 24, 2021 · 9 comments
Closed
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Monitor Monitor, Monitor Ingestion, Monitor Query question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@eladmotola
Copy link

Is your feature request related to a problem? Please describe.
While trying to get metrics of Microsoft.ServiceBus/namespaces/topics (Incoming messages) I got this error:
azure.core.exceptions.HttpResponseError: (BadRequest) Microsoft.ServiceBus/namespaces/topics is not a supported platform metric namespace

Describe the solution you'd like
Support Microsoft.ServiceBus/namespaces/topics as a valid metric via sdk

Describe alternatives you've considered
I dont have any.... or there is a workaround?

Additional context
Add any other context or screenshots about the feature request here.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 24, 2021
@eladmotola eladmotola changed the title Support Microsoft.ServiceBus/namespaces/topics monitor Support Microsoft.ServiceBus/namespaces/topics at azure.mgmt.monitor Mar 24, 2021
@eladmotola eladmotola changed the title Support Microsoft.ServiceBus/namespaces/topics at azure.mgmt.monitor Support Microsoft.ServiceBus/namespaces/topics in azure.mgmt.monitor Mar 24, 2021
@chlowell
Copy link
Member

Thanks for opening this issue, we'll investigate as soon as possible. In the meantime, can you please share a sample of your code, so it's clear which library and API you're using when you see this error?

@chlowell chlowell added Monitor - Metrics Service Attention Workflow: This issue is responsible by Azure service team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 24, 2021
@ghost
Copy link

ghost commented Mar 24, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @AzMonEssential.

Issue Details

Is your feature request related to a problem? Please describe.
While trying to get metrics of Microsoft.ServiceBus/namespaces/topics (Incoming messages) I got this error:
azure.core.exceptions.HttpResponseError: (BadRequest) Microsoft.ServiceBus/namespaces/topics is not a supported platform metric namespace

Describe the solution you'd like
Support Microsoft.ServiceBus/namespaces/topics as a valid metric via sdk

Describe alternatives you've considered
I dont have any.... or there is a workaround?

Additional context
Add any other context or screenshots about the feature request here.

Author: eladmotola
Assignees: lzchen
Labels:

Monitor - Metrics, Service Attention, customer-reported, question

Milestone: -

@eladmotola
Copy link
Author

eladmotola commented Mar 24, 2021

@chlowell Hey!
thank you for the quick reply

Code example:

monitor_client = MonitorManagementClient(credential, SUBSCRIPTION_ID)
today = datetime.datetime.utcnow()
five_min_before = (today - datetime.timedelta(minutes=5))
metrics_data = monitor_client.metrics.list(
'/subscriptions/__SUBSCRIPTION_ID__/resourceGroups/__rg__/providers/Microsoft.ServiceBus/namespaces/__namespace__/topics/__topic__',
        timespan=f"{five_min_before}/{today}",
        interval='PT1M',
        metricnames='IncomingMessages',
        aggregation='Maximum'
    )

library version:
azure-mgmt-monitor==2.0.0

@lzchen lzchen removed their assignment Mar 26, 2021
@chlowell chlowell added the Mgmt This issue is related to a management-plane library. label Mar 26, 2021
@msyyc msyyc assigned zhangyan133 and unassigned msyyc Mar 29, 2021
@eladmotola
Copy link
Author

@chlowell Hey,
Do you have any timeframe to share about this issue?

@chlowell
Copy link
Member

chlowell commented Apr 6, 2021

I don't; @zhangyan133, can you comment?

@eladmotola
Copy link
Author

eladmotola commented Apr 12, 2021

@chlowell @zhangyan133 Hey,
I see here:
https://docs.microsoft.com/en-us/azure/azure-monitor/essentials/metrics-supported#microsoftservicebusnamespaces

That I can pull IncomingMessages of each topic (Im assuming I should add the entityname in the dimension as mention) but I dont understand how to do it since "dimensions" is not a valid api.... any code example? I cant find anything about it and Ireally need this one

@chlowell
Copy link
Member

@msyyc can you help route this to the right person?

@msyyc msyyc assigned RAY-316 and unassigned msyyc and zhangyan133 Apr 13, 2021
@msyyc
Copy link
Member

msyyc commented Apr 13, 2021

@RAY-316 please provide help on this issue

@eladmotola
Copy link
Author

@chlowell Hey

Look like I had to add filter= EntityName eq '__topicname__'
Im closing

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Feb 16, 2022
Microsoft.App version 2022-01-01-preview (Azure#17820)

* New Swagger Spec File

* New Swagger Example Spec File

* New Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Go Language Readme Config File

* New Python Language Readme Config File

* New Typescript Language Readme Config File

* New C# Language Readme Config File

* Adding new API version 2022-01-01-preview for the new service Microsoft.App (Azure#17135)

* Adding swagger and examples

* Fix samples

* Fix linting errors

* fix errors

* fix more errors

* prettier fixes

* Fix the VNET properties

* fix the vnet props

* Attempt to remove x-ms-identifiers

* Add x-ms-identifiers back

* Revert "Add x-ms-identifiers back"

This reverts commit 44525ab5ace45d9cb1bc85bee2751f015dcaffc6.

* Addsourcecontrolapis (Azure#17287)

* add sourcecontrol apis

* remove space

* prettier fix

* typo

* avocado fix

* lint fix

* add replicas apis (Azure#17501)

* Remove Dapr components from ContainerApp spec. Not breaking because the version hasn't been released yet. (Azure#17479)

* Remove dapr components from the ContainerApp object

* Fix example

* add descriptions

* fix

* change the auto-rest parameters

* Support volume mounts for containerApp (Azure#17530)

* add volume mounts

* add identifier

* refine volume definition

* Fix samples (Azure#17534)

* Adding managed identity (Azure#17569)

* Adding managed identity

* prettier fix.

* Microsof.app 2022 01 01 preview/add custom domains (Azure#17385)

* add support for Custom domains and certificates

* add Certificates

* Ccertificate as child resource of Managed Env.

* Support default custom domain

* PUT/DELETE certificate are not long-running

* Add Custom Domain Verification Id

* domains for all revisions and adding examples

* missing examples

* one more missing example

* Examples+missing paths

* Adding missing envelope properties

* Addressing PR comments

* Removing AKV and Free cert related properties

* Prettier and semantic validation fixes

* Fixing semantic validations and examples

* More fixes

* Addressing more PR comments

* Updating examples

* fixing type

* fixing types

* Extra properties and responses

* misplaced response

* whitespace

* fix security section

* fixing ManageEnvironment securityDefinitions

* add 204 delete response

* Removing virtual IP and IP Based option

* change modelAsString

* Addressing ARM PR comments

* Removing 404 response from example

* renaming custom hostname analysis operation

* mark certificate as tracked resource

* fix sample

* Use Certificate Id instead of Certificate name

Co-authored-by: Ruslan Yakushev 🚴 <[email protected]>
Co-authored-by: vinisoto <[email protected]>

* Add new properties for ContainerApp (Azure#17483)

* add ephemeral storage

* add outbound ip

* add listsecrets

* fix CI

* fix example

* fix

* add identifier

* fix

* add example

* mars as secret

* Add storages operation for managedEnvironment (Azure#17545)

* add storage

* fix

* fix typo

* Add EasyAuth configuration APIs for ContainerApp (Azure#17492)

* Add Easy Auth Config related APIs for ContainerApp

* Use common type ProxyResource

* Update description

* update per validation

* typo fix

* fix validation error

* Update sample and description

* Update because ARM prefer string than boolean

* Add static web identity provider

* Add container probes (Azure#17535)

* Add container probes

* minor fix

* Use execute instead of exec'd, add identifier

* remove exec from preview

* use integer instead of intorstring

* Add `internal` property under VnetConfiguration for internalOnly environments (Azure#17656)

* Add internal property under VnetConfiguration for internalOnly environments

* Update examples

* Add Dapr Components collection APIs (Azure#17552)

* Add daprComponents

* update readme

* Fix linting errors

* More lint fixes

* prettier fixes

* make dapr component a tracked resource

* fix the patch

* fix lint errors

* Revert "fix lint errors"

This reverts commit 045f1d94bddf3527eab98b7a376070ab30fdd760.

* Revert "fix the patch"

This reverts commit 14521103e848e09762185f832c0270c16ed16efd.

* Revert "make dapr component a tracked resource"

This reverts commit 239268eda070ff37f26e8a772adacdd26bbf0937.

* Fix linter issues

* fix wrong fix

* fix linter

* fix the operationids (Azure#17809)

* correct resource name (Azure#17846)

* Add custom open id providers support (Azure#17855)

* Add custom open id providers support

* Update description

Co-authored-by: Xingjian Wang <[email protected]>
Co-authored-by: Zunli Hu <[email protected]>
Co-authored-by: Vaclav Turecek <[email protected]>
Co-authored-by: Vini Soto <[email protected]>
Co-authored-by: vinisoto <[email protected]>
Co-authored-by: erich-wang <[email protected]>
Co-authored-by: Mike Vu <[email protected]>
Co-authored-by: Sanchit Mehta <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Metrics labels Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Monitor Monitor, Monitor Ingestion, Monitor Query question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

7 participants