Set erroractionpreference for change log check

Azure · Mar 20, 2024 · 464d698 · 464d698
1 parent e6b698d
commit 464d698
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/eng/common/scripts/ChangeLog-Operations.ps1 b/eng/common/scripts/ChangeLog-Operations.ps1
@@ -148,6 +148,10 @@ function Confirm-ChangeLogEntry {
       Message = ""
     }
   }
+  else {
+    # Do not stop the script on error when status object is passed as param
+    $ErrorActionPreference = 'Continue'
+  }
   $changeLogEntries = Get-ChangeLogEntries -ChangeLogLocation $ChangeLogLocation
   $changeLogEntry = $changeLogEntries[$VersionString]
 

diff --git a/eng/common/scripts/Validate-All-Packages.ps1 b/eng/common/scripts/Validate-All-Packages.ps1
@@ -37,6 +37,7 @@ function ProcessPackage($PackageName, $ConfigFileDir)
         -Devops_pat $Devops_pat
     if ($LASTEXITCODE -ne 0) {
         Write-Error "Failed to validate package $PackageName"
+        exit 1
     }
 }
 

diff --git a/eng/common/scripts/Validate-Package.ps1 b/eng/common/scripts/Validate-Package.ps1
@@ -247,5 +247,6 @@ if ($IsReleaseBuild)
 {
     if (!$updatedWi -or $changelogStatus.Status -ne "Success" -or $apireviewDetails.ApiviewApproval.Status -ne "Approved" -or $apireviewDetails.PackageNameApproval.Status -ne "Approved") {        
         Write-Error "At least one of the Validations above failed for package $PackageName with version $versionString."
+        exit 1
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,6 +37,7 @@ function ProcessPackage($PackageName, $ConfigFileDir) @@
             -Devops_pat $Devops_pat
         if ($LASTEXITCODE -ne 0) {
             Write-Error "Failed to validate package $PackageName"
+            exit 1
         }
     }
@@ Expand Down @@