[Communication] Phone Number Administration: Rename list_all_orders -…

…> list_all_reservations (#15550)

* list_all_orders -> list_all_reservations

* update CHANGELOG

* flip SKIP_PHONE_NUMBER_TESTS boolean back

* update comment in async list_all_reservations

sdk/communication/azure-communication-administration/CHANGELOG.md

@@ -11,6 +11,7 @@ Caller must provide one of the following:
  (2) all of keywords `display_name`, `description`, `phone_plan_ids`, `area_code`, `quantity`, `location_options`
  if at least one phone plan to reserve is not toll-free plans.
  (3) only keyword `continuation_token` to restart a poller from a saved state.
+-  `list_all_orders` renamed to `list_all_reservations`.
 
 ## 1.0.0b3 (2020-11-16)
 

sdk/communication/azure-communication-administration/azure/communication/administration/_phone_number_administration_client.py

@@ -514,12 +514,12 @@ def begin_reserve_phone_numbers(
                          polling_method=reservation_polling)
 
     @distributed_trace
-    def list_all_searches(
+    def list_all_reservations(
             self,
             **kwargs  # type: Any
     ):
         # type: (...) -> ItemPaged[PhoneNumberEntities]
-        """Gets a list of all searches.
+        """Gets a list of all reservations.
 
         :keyword int skip: An optional parameter for how many entries to skip, for pagination purposes.
         The default is 0.

sdk/communication/azure-communication-administration/azure/communication/administration/aio/_phone_number_administration_client_async.py

@@ -523,12 +523,12 @@ async def begin_reserve_phone_numbers(
                          polling_method=reservation_polling)
 
     @distributed_trace
-    def list_all_searches(
+    def list_all_reservations(
             self,
             **kwargs  # type: Any
     ):
         # type: (...) -> AsyncItemPaged[PhoneNumberEntities]
-        """Gets a list of all searches.
+        """Gets a list of all reservations.
 
         :keyword int skip: An optional parameter for how many entries to skip, for pagination purposes.
         The default is 0.

sdk/communication/azure-communication-administration/tests/test_phone_number_administration_client.py

@@ -274,3 +274,9 @@ def test_purchase_reservation(self):
             reservation_id=self.reservation_id_to_purchase
         )
         assert poller.result()
+
+    @pytest.mark.live_test_only
+    @pytest.mark.skipif(SKIP_PHONE_NUMBER_TESTS, reason=PHONE_NUMBER_TEST_SKIP_REASON)
+    def test_list_reservations(self):
+        pages = self._phone_number_administration_client.list_all_reservations()
+        assert pages.next()

sdk/communication/azure-communication-administration/tests/test_phone_number_administration_client_async.py

@@ -335,3 +335,14 @@ async def test_purchase_reservation(self):
             )
             result = await poller.result()
         assert result
+
+    @AsyncPhoneNumberCommunicationTestCase.await_prepared_test
+    @pytest.mark.live_test_only
+    @pytest.mark.skipif(SKIP_PHONE_NUMBER_TESTS, reason=PHONE_NUMBER_TEST_SKIP_REASON)
+    async def test_list_reservations(self):
+        async with self._phone_number_administration_client:
+            pages = self._phone_number_administration_client.list_all_reservations()
+            items = []
+            async for item in pages:
+                items.append(item)
+        assert len(items) > 0