[Storage] STG94 GA API View Feedback (#36208)

Azure · Jul 10, 2024 · 2ca0b6f · 2ca0b6f
1 parent 30dd82c
commit 2ca0b6f
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 10 deletions.
diff --git a/sdk/storage/azure-storage-file-share/CHANGELOG.md b/sdk/storage/azure-storage-file-share/CHANGELOG.md
@@ -8,7 +8,6 @@
 ## 12.17.0b1 (2024-06-11)
 
 ### Features Added
-- Added `enable_snapshot_virtual_directory_access` parameter support for NFS shares on premium-tier Storage accounts.
 - Added a more descriptive authorization error message when facing authorization errors.
 
 ## 12.16.0 (2024-05-07)

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
@@ -343,7 +343,7 @@ class ShareProperties(DictMixin):
         Indicates the protocols enabled on the share. The protocol can be either SMB or NFS.
     :ivar bool enable_snapshot_virtual_directory_access:
         Specifies whether the snapshot virtual directory should be accessible at the root of the share
-        mount point when NFS is enabled. if not specified, the default is True.
+        mount point when NFS is enabled. If not specified, it will be accessible.
     """
 
     def __init__(self, **kwargs):

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py
@@ -374,9 +374,6 @@ def create_share(self, **kwargs):
             Root squash to set on the share.
             Only valid for NFS shares. Possible values include: 'NoRootSquash', 'RootSquash', 'AllSquash'.
         :paramtype root_squash: str or ~azure.storage.fileshare.ShareRootSquash
-        :keyword bool enable_snapshot_virtual_directory_access:
-            Specifies whether the snapshot virtual directory should be accessible at the root of the share
-            mount point when NFS is enabled. Default value is True.
         :returns: Share-updated property dict (Etag and last modified).
         :rtype: Dict[str, Any]
 

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_share_client_async.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_share_client_async.py
@@ -223,9 +223,6 @@ async def create_share(self, **kwargs):
             Root squash to set on the share.
             Only valid for NFS shares. Possible values include: 'NoRootSquash', 'RootSquash', 'AllSquash'.
         :paramtype root_squash: str or ~azure.storage.fileshare.ShareRootSquash
-        :keyword bool enable_snapshot_virtual_directory_access:
-            Specifies whether the snapshot virtual directory should be accessible at the root of the share
-            mount point when NFS is enabled. Default value is True.
         :returns: Share-updated property dict (Etag and last modified).
         :rtype: Dict[str, Any]
 

diff --git a/sdk/storage/azure-storage-file-share/tests/test_share.py b/sdk/storage/azure-storage-file-share/tests/test_share.py
@@ -759,7 +759,7 @@ def test_list_shares_enable_snapshot_virtual_directory_access(self, **kwargs):
         premium_storage_file_account_key = kwargs.pop("premium_storage_file_account_key")
 
         self._setup(premium_storage_file_account_name, premium_storage_file_account_key)
-        share = self._create_share(protocols="NFS", enable_snapshot_virtual_directory_access=False)
+        share = self._create_share(protocols="NFS", headers={'x-ms-enable-snapshot-virtual-directory-access': "False"})
 
         # Act
         list_props = list(self.fsc.list_shares())

diff --git a/sdk/storage/azure-storage-file-share/tests/test_share_async.py b/sdk/storage/azure-storage-file-share/tests/test_share_async.py
@@ -756,7 +756,7 @@ async def test_list_shares_enable_snapshot_virtual_directory_access(self, **kwar
         premium_storage_file_account_key = kwargs.pop("premium_storage_file_account_key")
 
         self._setup(premium_storage_file_account_name, premium_storage_file_account_key)
-        share = await self._create_share(protocols="NFS", enable_snapshot_virtual_directory_access=False)
+        share = await self._create_share(protocols="NFS", headers={'x-ms-enable-snapshot-virtual-directory-access': "False"})
 
         # Act
         list_props = []