Add Azure.Storage meta-package #8826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
requested review from
amnguye,
JoshLove-msft and
seanmcc-msft
as code owners
loic-sharma
reviewed
Nov 19, 2019
loic-sharma
reviewed
Nov 19, 2019
weshaggard
force-pushed
the
AddStorageMetaPackage
branch
from
4276340
to
809df18
Compare
weshaggard
force-pushed
the
AddStorageMetaPackage
branch
from
809df18
to
347359f
Compare
tg-msft
reviewed
Nov 20, 2019
| dotnet add package Azure.Storage | ||
| ``` | ||
|
|
||
| ### Prerequisites |
There was a problem hiding this comment.
Should we bother with all these empty or copy/pasted sections and just link folks to the other readmes?
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| Azure Storage is a Microsoft-managed service providing cloud storage that is highly available, secure, durable, scalable, and redundant. Azure Storage includes Blobs (objects), Queues, and Files. | |||
|
|
|||
| - [Azure.Storage][meta] This is our storage meta-package that references the most common storage libraries, for the time being it only references Blobs. | |||
There was a problem hiding this comment.
Can we move this last after the other Azure.Storage packages? I don't want folks to start here.
|
|
||
| <PackageTags>Storage;Blobs;$(PackageCommonTags)</PackageTags> | ||
| <Description> | ||
| Package that references the common Azure Storage libraries for things like blob manipulation. |
There was a problem hiding this comment.
Package that references all Microsoft Azure Storage libraries? They brand as Microsoft Azure Storage in our other packages and we'll probably forget to update this every time we add additional references.
|
We have decided to not ship this at this point so I'm closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tg-msft @AlexGhiondea
Fixes #8728