-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Databox] SDK refresh to support new API version (2019-09-01) #8219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refreshing SDK with support for new API version
* Added recorded tests
* Refreshing SDK with support for new API version
* Added recorded tests
Can one of the admins verify this patch? |
isra-fel
suggested changes
Oct 21, 2019
@@ -7,23 +7,20 @@ | |||
<PackageId>Microsoft.Azure.Management.DataBox</PackageId> | |||
<Description>Microsoft Azure Management DataBox library</Description> | |||
<AssemblyName>Microsoft.Azure.Management.DataBox</AssemblyName> | |||
<Version>1.0.1</Version> | |||
<Version>1.2.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, please use 1.1.0
@@ -8,7 +8,7 @@ | |||
[assembly: AssemblyDescription("Provides Microsoft Azure DataBox management functions for managing the Microsoft Azure DataBox service.")] | |||
|
|||
[assembly: AssemblyVersion("1.0.0")] | |||
[assembly: AssemblyFileVersion("1.0.1")] | |||
[assembly: AssemblyFileVersion("1.2.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
isra-fel
added
Mgmt
This issue is related to a management-plane library.
needs-revision
and removed
needs-review
labels
Oct 21, 2019
isra-fel
suggested changes
Oct 22, 2019
sdk/databox/Microsoft.Azure.Management.DataBox/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
isra-fel
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Spec PR : Azure/azure-rest-api-specs#7317