Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafactory] Enable Avro Dataset in SDK #7112

Merged
merged 4 commits into from
Aug 7, 2019
Merged

[Datafactory] Enable Avro Dataset in SDK #7112

merged 4 commits into from
Aug 7, 2019

Conversation

yuzhangyi
Copy link
Contributor

No description provided.

@yuzhangyi yuzhangyi requested a review from erich-wang as a code owner August 5, 2019 07:45
@erich-wang
Copy link
Member

@yuzhangyi , please follow the instruction to update the PR. Considering swagger spec is the contract between SDK and service team, any change in master branch should be ready for generating SDK. I think you don't worry about that the generated code contains someone else's change.

erich-wang
erich-wang suggested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@erich-wang erich-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add related swagger spec PR related to this PR as well.

@erich-wang erich-wang self-assigned this Aug 6, 2019
@yuzhangyi
Copy link
Contributor Author

ger spec PR related to this PR as well

Related change of public swagger is here: Azure/azure-rest-api-specs#6816

@yuzhangyi
Copy link
Contributor Author

@yuzhangyi , please follow the instruction to update the PR. Considering swagger spec is the contract between SDK and service team, any change in master branch should be ready for generating SDK. I think you don't worry about that the generated code contains someone else's change.

I have updated it based on the "instruction", @erich-wang, please help review it again, thanks!

@erich-wang erich-wang merged commit 187b372 into Azure:master Aug 7, 2019
pull bot pushed a commit to test-repo-billy/azure-sdk-for-net that referenced this pull request Aug 7, 2019
@yuzhangyi @pull
[Datafactory] Enable Avro Dataset in SDK (Azure#7112)
d7314fe 
* [Datafactory] Enable Avro Dataset in SDK

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erich-wang erich-wang erich-wang approved these changes

Assignees

@erich-wang erich-wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuzhangyi @erich-wang @zhanyu2024