Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retries to Invoke-WebRequest, update to PowerShell 6 #7030

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Add retries to Invoke-WebRequest, update to PowerShell 6 #7030

merged 1 commit into from
Jul 26, 2019

Conversation

mikeharder
Copy link
Member

  • Downloads may occasionally fail due to server or network issues
  • Normalized whitespace and quote

CC: @Azure/azure-sdk-eng

@mikeharder
Add retries to Invoke-WebRequest, update to PowerShell 6
31f7294 
- Downloads may occasionally fail due to server or network issues
@mikeharder mikeharder requested a review from mitchdenny as a code owner July 25, 2019 19:52
@mikeharder
Copy link
Member Author

@chidozieononiwu, @scbedd: I would like to run pipeline net - docs to verify my changes to docs.yml, however I noticed the pipeline runs against branch PublishDocsToGithub instead of master. Is it safe to run this pipeline against my PR?

@chidozieononiwu
Copy link
Member

chidozieononiwu commented Jul 25, 2019 •
edited
Loading

@chidozieononiwu, @scbedd: I would like to run pipeline net - docs to verify my changes to docs.yml, however I noticed the pipeline runs against branch PublishDocsToGithub instead of master. Is it safe to run this pipeline against my PR?
@mikeharder Yes its safe, I have updated the release. You can run it against your PR.

@mikeharder mikeharder mentioned this pull request Jul 25, 2019
Closed
4 tasks
@mikeharder
Copy link
Member Author

@weshaggard: Does this look good enough to you? I will clean up the .prettierrc in a later PR.

@mikeharder mikeharder merged commit a1d20dd into Azure:master Jul 26, 2019
@mikeharder mikeharder deleted the invoke-webrequest-retry branch July 26, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@scbedd scbedd Awaiting requested review from scbedd

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeharder @chidozieononiwu @weshaggard