Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to a new analyzer package #6946

Merged
merged 5 commits into from
Jul 16, 2019
Merged

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Jul 16, 2019

It includes double newline and whitespace before line end analyzers.

Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to be a blood bath of a diff when we turn these on for Storage... I'll aim to do that sooner than later.

@pakrym
Copy link
Contributor Author

pakrym commented Jul 16, 2019

It's going to be a blood bath of a diff when we turn these on for Storage... I'll aim to do that sooner than later.

I'll do it as part of this PR.

@tg-msft
Copy link
Member

tg-msft commented Jul 16, 2019

So much for all the conspiracy theories I encoded via whitespace stenography in the Storage source...

but thanks for enabling them because now's a great time to make the change. I filed #6947 to turn the rest of them on.

eng/Packages.Data.props Outdated Show resolved Hide resolved
@pakrym pakrym merged commit 40cf7ce into Azure:master Jul 16, 2019
@pakrym pakrym deleted the pakrym/pull-ws-analyzers branch July 16, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants