Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing communicationException when it is connectionError #6942

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

nemakam
Copy link
Contributor

@nemakam nemakam commented Jul 16, 2019

Multiple errors can happen when link/session is closing. Throw ServiceBusCommunicationException instead of ServiceBusException.

Fixes #6097

@nemakam nemakam requested review from binzywu and vinaysurya July 16, 2019 02:59
@nemakam nemakam self-assigned this Jul 16, 2019
@nemakam nemakam merged commit 58b0c96 into Azure:master Jul 16, 2019
@nemakam nemakam deleted the communicationException branch July 16, 2019 23:57
@ocengiz0
Copy link

ocengiz0 commented Sep 2, 2019

Does V4.0.0 include this fix?

@nemakam
Copy link
Contributor Author

nemakam commented Oct 4, 2019

@ocengiz0
Copy link

ocengiz0 commented Oct 8, 2019

@nemakam I still get errors.

I am using the same code which is given as a sample here:
https://github.com/Azure/azure-service-bus/tree/master/samples/DotNet/GettingStarted/Microsoft.Azure.ServiceBus/BasicSendReceiveUsingQueueClient

ExceptionReceivedHandler receives lots of The operation was canceled. error.

Can you comment?

@nemakam
Copy link
Contributor Author

nemakam commented Oct 8, 2019

@ocengiz0
Could you share the stack trace? Is there a different stack trace?
There's also another PR #7935 in line for next release which blocks OperationCanceledException during handler close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The operation was canceled
4 participants