Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HTTP related types to http namespace, and policy types to Azure.Core.Pipeline #6939

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Jul 16, 2019

Contributes to #6831

Breaking change:

Namespace adjustments.

@pakrym pakrym requested review from tg-msft, maririos and schaabs July 16, 2019 00:13
@pakrym pakrym changed the title Move HTTP related types to http namespace Move HTTP related types to http namespace, and policy types to Azure.Core.Pipeline Jul 16, 2019
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tag it as a BreakingChange, but it looks good otherwise.

{
public class TelemetryPolicy : SynchronousHttpPipelinePolicy
internal class TelemetryPolicy : SynchronousHttpPipelinePolicy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional? It's the only non-namespace change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed that I forgot TelemetryPolicy when making build-in policies internal.

@pakrym pakrym merged commit f31e18d into Azure:master Jul 16, 2019
@pakrym pakrym deleted the pakrym/http-ns branch July 16, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants