Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key docs update after feedback #6925

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Key docs update after feedback #6925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/keyvault/Azure.Security.KeyVault.Keys/Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ $Env:AZURE_TENANT_ID="tenant-ID"

* Grant the above mentioned application authorization to perform key operations on the key vault:
```PowerShell
az keyvault set-policy --name <your-key-vault-name> --spn $AZURE_CLIENT_ID --key-permissions backup delete get list set
az keyvault set-policy --name <your-key-vault-name> --spn $AZURE_CLIENT_ID --key-permissions backup delete get list create
```
> --key-permissions:
> Accepted values: backup, delete, get, list, purge, recover, restore, set
> Accepted values: backup, create, decrypt, delete, encrypt, get, import, list, purge, recover, restore, sign, unwrapKey, update, verify, wrapKey

* Use the above mentioned Key Vault name to retrieve details of your Vault which also contains your Key Vault URL:
```PowerShell
Expand Down Expand Up @@ -148,7 +148,7 @@ Key key = client.CreateKey("key-name", KeyType.EllipticCurve);
// You can specify additional application-specific metadata in the form of tags.
key.Tags["foo"] = "updated tag";

KeyBase updatedKey = client.UpdateKey(key);
KeyBase updatedKey = client.UpdateKey(key, key.KeyMaterial.KeyOps);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a comment on the docs but KeyOps should be optional on update key.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #6932 created


Console.WriteLine(updatedKey.Name);
Console.WriteLine(updatedKey.Version);
Expand Down
2 changes: 2 additions & 0 deletions sdk/keyvault/Azure.Security.KeyVault.Secrets/tests/SecretClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ public async Task DeleteSecret()
DeletedSecret deletedSecret = await Client.DeleteAsync(secretName);

AssertSecretsEqual(secret, deletedSecret);
Assert.NotNull(deletedSecret.DeletedDate);
Assert.NotNull(deletedSecret.ScheduledPurgeDate);

Assert.ThrowsAsync<RequestFailedException>(() => Client.GetAsync(secretName));
}
Expand Down