Unblock message pump while receiving message #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version of the code blocked further task processing with more Tasks being created while message was being received up until the point when message processing actually started. With switch from await to ContinueWith execution of the rest of the method is continued asynchronously allowing `MaxConcurrentCalls` to be higher than number of logical processors on the target machine.
alexander-rakov
force-pushed
the
servicebus-fix-messagereceivepump-async
branch
from
9c36949 to
4e2f7e5
Compare
|
Can one of the admins verify this patch? |
|
Looks like |
jsquire
added
Client
vinaysurya
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of the code blocked further task processing with more
Tasks being created while message was being received up until the point
when message processing actually started.
With switch from await to ContinueWith execution of the rest of the
method is continued asynchronously allowing
MaxConcurrentCallsto behigher than number of logical processors on the target machine.