Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session pump stops on some exceptions #6485

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Fix session pump stops on some exceptions #6485

merged 1 commit into from
Jul 8, 2019

Conversation

inech
Copy link
Contributor

@inech inech commented Jun 5, 2019

Reproduction:

  1. Send some messages with different sessions to a queue.
  2. Register the session handler sessionClient.RegisterSessionHandler(MessageHandler, new SessionHandlerOptions(ExceptionReceivedHandler) {MaxConcurrentSessions = 1, MessageWaitTimeout = TimeSpan.FromSeconds(5)});
  3. See messages being processed.
  4. Disable the queue.
  5. See some exceptions happening.
  6. After some time enable the queue.
  7. Expected: Session handler continues to process messages. Actual: Session handler is stuck until recreated.

P.S. For non-sessioned queues it works correctly. When using queueClient.RegisterMessageHandler(MessageHandler...) and then disabling & enabling it the queue, message processing continues as expected. This PR implements the same behavior for sessioned-queues.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jsquire jsquire added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus labels Jun 21, 2019
@jsquire jsquire merged commit ad5ee5d into Azure:master Jul 8, 2019
@jsquire
Copy link
Member

jsquire commented Jul 8, 2019

Merging per request from Neeraj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants