Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IoTCentral - Add ARM endpoint, update model responses/inputs, update tests #4909

Merged
merged 3 commits into from
Oct 30, 2018
Merged

IoTCentral - Add ARM endpoint, update model responses/inputs, update tests #4909

merged 3 commits into from
Oct 30, 2018

Conversation

r-delgadillo
Copy link
Contributor

  • Added a new endpoint to check the availability of application subdomain.
  • Updated unit tests

REST spec PR: Azure/azure-rest-api-specs#4015

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@r-delgadillo
Copy link
Contributor Author

r-delgadillo commented Oct 22, 2018 •
edited
Loading

Add @emgarten @zzcodework @amrenbin @cle5eland @vavilla

dsgouda
dsgouda suggested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please squash commits into a single commit and address the comment below. We should be good to merge

src/SDKs/IotCentral/IotCentral.Tests/IotCentral.Tests.csproj Outdated Show resolved Hide resolved
@r-delgadillo
Copy link
Contributor Author

Thank you for the feedback @dsgouda. Is anything else required for this PR?

@dsgouda
Copy link
Contributor

dsgouda commented Oct 30, 2018

@r-delgadillo please address the last comments I left on this PR

@dsgouda
Copy link
Contributor

dsgouda commented Oct 30, 2018

@r-delgadillo please squash commits into a single commit

@r-delgadillo r-delgadillo reopened this Oct 30, 2018
@r-delgadillo
Copy link
Contributor Author

@dsgouda Is this ok?

dsgouda
dsgouda approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, will merge once CIs pass

@r-delgadillo
Copy link
Contributor Author

@dsgouda May we get this merged today? 😄

@dsgouda dsgouda merged commit 15dec74 into Azure:psSdkJson6 Oct 30, 2018
ahamad-MS pushed a commit to ahamad-MS/azure-sdk-for-net that referenced this pull request Oct 31, 2018
@r-delgadillo
Add ARM endpoint, update model responses/inputs, update tests (Azure#…
43f39e5 
…4909)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@emgarten emgarten emgarten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-delgadillo @dsgouda @emgarten