Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reservations RP 2018-06-01: Add CosmosDb type in Reserved resource ty… #4724

Closed
wants to merge 1 commit into from
Closed

Conversation

luluRagdoll
Copy link

@luluRagdoll luluRagdoll commented Aug 30, 2018

…pe enum. Add name property in PatchProperties

Description

Add "CosmosDb" in the reservedResourceType enum
Add "name" property in the PatchProperties


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

…pe enum. Add name property in PatchProperties
@dsgouda
Copy link
Contributor

dsgouda commented Aug 30, 2018

Incorrect PR

@dsgouda dsgouda closed this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants