Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playwrighttesting): logger name and flaky tests #46746

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix(playwrighttesting): logger name and flaky tests #46746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc48f24
fix(): logger name and flaky tests
Oct 22, 2024
c3d1ceb
fix(): run name fetching logic name from git
Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...icrosoftPlaywrightTesting.NUnit/samples/Sample1_CustomisingServiceParameters.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,15 @@ This guide explains the different options available to you in the Azure.Develope
<!-- The below parameters are optional -->
<Parameter name="Os" value="linux" />
<Parameter name="RunId" value="sample-run-id" />
<Parameter name="ExposeNetwork" value="<loopback>" />
<Parameter name="ServiceAuthType" value="EntraId" />
<Parameter name="UseCloudHostedBrowsers" value="true" />
<Parameter name="AzureTokenCredentialType" value="DefaultAzureCredential" />
<Parameter name="ManagedIdentityClientId" value="77bfc267-86cb-4eeb-9e4a-747a217a318c" />
<Parameter name="EnableGitHubSummary" value="false" />
</TestRunParameters>
<!-- Enable Reporting feature -->
<LoggerRunSettings>
<Loggers>
<Logger friendlyName="ms-playwright-service" enabled="true" />
<Logger friendlyName="microsoft-playwright-testing" enabled="true" />
</Loggers>
</LoggerRunSettings>
</RunSettings>
Expand Down
2 changes: 1 addition & 1 deletion ...esting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/Utility/ReporterUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ internal static string GetRunName(CIInfo ciInfo)
{
string GIT_VERSION_COMMAND = "git --version";
string GIT_REV_PARSE = "git rev-parse --is-inside-work-tree";
string GIT_COMMIT_MESSAGE_COMMAND = "git log -1 --pretty=%B";
string GIT_COMMIT_MESSAGE_COMMAND = "git log -1 --pretty=format:\"%s\"";

if (ciInfo.Provider == CIConstants.s_gITHUB_ACTIONS &&
Environment.GetEnvironmentVariable("GITHUB_EVENT_NAME") == "pull_request")
Expand Down
1 change: 0 additions & 1 deletion ...zure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/Utility/CiInfoProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
namespace Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Tests.Utility
{
[TestFixture]
[Parallelizable(ParallelScope.Self)]
public class CiInfoProviderTests
{
private Dictionary<string, string> _originalEnvironmentVariables = new();
Expand Down
1 change: 0 additions & 1 deletion ...Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/Utility/ReporterUtilsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
namespace Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Tests.Utility;

[TestFixture]
[Parallelizable(ParallelScope.Self)]
public class ReporterUtilsTests
{
private static string GetToken(Dictionary<string, object> claims, DateTime? expires = null)
Expand Down