Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityCenter] Remove ingore attribute and fix the recording file after iothub and logic release #46659

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[SecurityCenter] Remove ingore attribute and fix the recording file after iothub and logic release #46659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/securitycenter/Azure.ResourceManager.SecurityCenter/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/securitycenter/Azure.ResourceManager.SecurityCenter",
"Tag": "net/securitycenter/Azure.ResourceManager.SecurityCenter_4103de93a6"
"Tag": "net/securitycenter/Azure.ResourceManager.SecurityCenter_4d5901f3b9"
}
4 changes: 2 additions & 2 deletions ...re.ResourceManager.SecurityCenter/tests/Azure.ResourceManager.SecurityCenter.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<ItemGroup>
<PackageReference Include="Azure.ResourceManager.Compute" />
<PackageReference Include="Azure.ResourceManager.IotHub" VersionOverride="1.0.0" />
<PackageReference Include="Azure.ResourceManager.Logic" VersionOverride="1.0.0" />
<PackageReference Include="Azure.ResourceManager.IotHub" VersionOverride="1.2.0-beta.1" />
<PackageReference Include="Azure.ResourceManager.Logic" VersionOverride="1.2.0-beta.1" />
<PackageReference Include="Azure.ResourceManager.Network" />
</ItemGroup>
<ItemGroup>
Expand Down
6 changes: 0 additions & 6 deletions ...tycenter/Azure.ResourceManager.SecurityCenter/tests/Scenario/AutomationCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ private async Task<SecurityAutomationResource> CreateSecurityAutomation(string a
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task CreateOrUpdate()
{
string automationName = Recording.GenerateAssetName("automation");
Expand All @@ -76,7 +75,6 @@ public async Task CreateOrUpdate()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task Exist()
{
string automationName = Recording.GenerateAssetName("automation");
Expand All @@ -86,7 +84,6 @@ public async Task Exist()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task Get()
{
string automationName = Recording.GenerateAssetName("automation");
Expand All @@ -96,7 +93,6 @@ public async Task Get()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]

public async Task GetAll()
{
Expand All @@ -108,7 +104,6 @@ public async Task GetAll()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task Delete()
{
string automationName = Recording.GenerateAssetName("automation");
Expand All @@ -124,7 +119,6 @@ public async Task Delete()
[TestCase(null)]
[TestCase(false)]
[TestCase(true)]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task AddRemoveTag(bool? useTagResource)
{
SetTagResourceUsage(Client, useTagResource);
Expand Down
1 change: 0 additions & 1 deletion ...er/Azure.ResourceManager.SecurityCenter/tests/Scenario/IotSecurityAggregatedAlertTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public async Task Dismiss()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task GetAll()
{
var list = await _iotSecurityAggregatedAlertCollection.GetAllAsync().ToEnumerableAsync();
Expand Down
1 change: 0 additions & 1 deletion ...ResourceManager.SecurityCenter/tests/Scenario/IotSecurityAggregatedRecommendationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public async Task Get()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task GetAll()
{
var list = await _iotSecurityAggregatedRecommendationCollection.GetAllAsync().ToEnumerableAsync();
Expand Down
6 changes: 0 additions & 6 deletions ...itycenter/Azure.ResourceManager.SecurityCenter/tests/Scenario/IotSecuritySolutionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public async Task TestSetUp()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task CreateOrUpdate()
{
string solutionName = Recording.GenerateAssetName("solution");
Expand All @@ -42,7 +41,6 @@ public async Task CreateOrUpdate()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task Exist()
{
string solutionName = Recording.GenerateAssetName("solution");
Expand All @@ -52,7 +50,6 @@ public async Task Exist()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task Get()
{
string solutionName = Recording.GenerateAssetName("solution");
Expand All @@ -62,7 +59,6 @@ public async Task Get()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task GetAll()
{
string solutionName = Recording.GenerateAssetName("solution");
Expand All @@ -73,7 +69,6 @@ public async Task GetAll()
}

[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task Delete()
{
string solutionName = Recording.GenerateAssetName("solution");
Expand All @@ -89,7 +84,6 @@ public async Task Delete()
[TestCase(null)]
[TestCase(false)]
[TestCase(true)]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task AddRemoveTag(bool? useTagResource)
{
SetTagResourceUsage(Client, useTagResource);
Expand Down