Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playwighttesting): Removed cancellationToken from SetupAsync method since NUnit does not allow additional params #46566

Merged
merged 4 commits into from
Oct 14, 2024
Merged

fix(playwighttesting): Removed cancellationToken from SetupAsync method since NUnit does not allow additional params #46566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9227139
Removed parameter from SetupAsync method.
Oct 11, 2024
1e81635
update
Oct 11, 2024
a508c5f
undo last commit
Oct 11, 2024
7a4b967
update
Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rightTesting.NUnit/api/Azure.Developer.MicrosoftPlaywrightTesting.NUnit.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ public partial class PlaywrightServiceNUnit : Azure.Developer.MicrosoftPlaywrigh
public PlaywrightServiceNUnit(Azure.Core.TokenCredential? credential = null) : base (default(Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.PlaywrightServiceOptions), default(Azure.Core.TokenCredential)) { }
public static Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.PlaywrightServiceOptions playwrightServiceOptions { get { throw null; } }
[NUnit.Framework.OneTimeSetUpAttribute]
public System.Threading.Tasks.Task SetupAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public System.Threading.Tasks.Task SetupAsync() { throw null; }
[NUnit.Framework.OneTimeTearDownAttribute]
public void Teardown() { }
}
Expand Down
5 changes: 2 additions & 3 deletions ...ghttesting/Azure.Developer.MicrosoftPlaywrightTesting.NUnit/src/PlaywrightServiceNUnit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,11 @@ public PlaywrightServiceNUnit(TokenCredential? credential = null)
/// <summary>
/// Setup the resources utilized by Playwright service.
/// </summary>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns></returns>
[OneTimeSetUp]
public async Task SetupAsync(CancellationToken cancellationToken = default)
public async Task SetupAsync()
{
await InitializeAsync(cancellationToken).ConfigureAwait(false);
await InitializeAsync().ConfigureAwait(false);
}

/// <summary>
Expand Down