[Fleet] Adding rahuls-microsoft to code owners #46554
Merged
+795
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion (#46013) * Add flag and enable CAE to AuthorizeRequestInternal * Enable CAE for AuthorizeRequestOnChallenge * Add flag in SecretClientOption and SecretClient * Revert "Add flag in SecretClientOption and SecretClient" This reverts commit 02a805d. * Enable CAE by default * Removing unused parameter * Remove saving the claims in the cache * Update Changelog * Update changelogs * Simplify error checking logic Addressing comment in PR * Add test for base64 claims * Override Process function to handle the first CAE Challenge after a scope challenge * Add tests * Separate credential and client transports and assert for a 401. * Nest rety inside challenge if block * Add test for claims in token * Fix CI by removing extra test case parameter * Nit changes to tests * Simplify tests * removing unnecessary mock responses * Refactor tests to test CAE in all projects * Make tests non parallelizable * Add setup method to CAE tests * Test for tokens obtained from cae challenges * Fix test / CI * Update dependency for System.ClientModel * Apply suggestions
rahuls-microsoft
requested review from
JoshLove-msft,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft,
jsquire,
m-nash,
ArthurMa1978,
schaabs and
JonathanCrd
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fleet] Adding rahuls-microsoft to code owners