-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Text Analytics C# SDK auto-generated code. #4589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great apart from the minor comment
@@ -6,7 +6,7 @@ | |||
<PropertyGroup> | |||
<PackageId>Microsoft.Azure.CognitiveServices.Language.TextAnalytics</PackageId> | |||
<Description>This client library provides access to the Microsoft Cognitive Services Language APIs.</Description> | |||
<Version>2.0.0-preview</Version> | |||
<Version>2.1.0-preview</Version> | |||
<AssemblyName>Microsoft.Azure.CognitiveServices.Language.TextAnalytics</AssemblyName> | |||
<PackageTags>Microsoft Cognitive Services;Cognitive Services;Cognitive Services SDK;Text Analytics API;Text Analytics;REST HTTP client;netcore451511</PackageTags> | |||
<PackageReleaseNotes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PackageReleaseNotes
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will merge on CIs passing |
@dsgouda weird it failed because some package issue. I so rebased to newest psSdkJson6 to see if it works. |
@dsgouda, it seems to be an issue in Batch: |
@yangyuan kicked off another build. Will investigate if this fails |
@dsgouda still falls, same error. |
@yangyuan We are fixing it now |
Swagger PR: Azure/azure-rest-api-specs#3491
Doc PR: MicrosoftDocs/azure-docs#12442
Please hold for @assafi's review.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.