Implement objectId support for ManagedIdentityCredential #45605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
requested review from
maorleger,
pvaneck,
billwert,
ahsonkhan,
KarishmaGhiya and
mpodwysocki
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
scottaddie
reviewed
Aug 21, 2024
Co-authored-by: Scott Addie <[email protected]>
|
/azp run net - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This README section should be updated to show you can use object ID too: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/README.md#authenticate-with-a-user-assigned-managed-identity |
schaabs
reviewed
Aug 29, 2024
sdk/identity/Azure.Identity/src/Credentials/ManagedIdentityCredentialOptions.cs
Show resolved
Hide resolved
sdk/identity/Azure.Identity/src/Credentials/ManagedIdentityCredential.cs
Show resolved
Hide resolved
sdk/identity/Azure.Identity/src/Credentials/ManagedIdentityCredential.cs
Show resolved
Hide resolved
sdk/identity/Azure.Identity/src/ImdsManagedIdentityProbeSource.cs
Outdated
Show resolved
Hide resolved
scottaddie
reviewed
Sep 3, 2024
scottaddie
reviewed
Sep 4, 2024
schaabs
approved these changes
Sep 4, 2024
scottaddie
approved these changes
Sep 4, 2024
sdk/identity/Azure.Identity/src/AzureArcManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Scott Addie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2131