Set OperationId for incomplete LRO #44098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
ArthurMa1978
approved these changes
May 17, 2024
annelo-msft
reviewed
May 17, 2024
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
May 17, 2024
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
May 17, 2024
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
May 17, 2024
jsquire
requested changes
May 18, 2024
There was a problem hiding this comment.
Before we add more functionality to this, I'd like to be sure that we restore AOT compatibility, which was inadvertently broken by the initial LRO rehydration PR.
Since this is shared source used by a wide array of libraries, this effectively renders any consumer with paging non-AOT compatible, which is an issue for those we have committed to being part of the ASP.NET Core critical path, such as KeyVault and Monitor.
see: #44127
If there is a critical need for this PR to merge, please let me know and we can work together on a plan to ensure that the AOT fixes are prioritized after this closes.
jsquire
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44097