[Messaging] Relax emulator endpoint restrictions #44052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to remove the restriction that the endpoint used in connection strings must resolve to a variant of `localhost` when using the development emulator. A fix to parsing was also made to be resilient to an endpoint with no scheme that specifies a custom port. Previously, this would parse incorrectly and be rejected. The scenario is now detected and parsed. Also included is a package bump for the AMQP transport library and release prep for the Event Hubs core package.
jsquire
added
Service Bus
Event Hubs
Client
jsquire
requested review from
annelo-msft,
KrzysztofCwalina,
tg-msft,
pallavit,
m-nash and
ArthurMa1978
as code owners
|
API change check API changes are not detected in this pull request. |
jsquire
commented
May 15, 2024
sdk/eventhub/Azure.Messaging.EventHubs/src/EventHubsConnectionStringProperties.cs
Show resolved
Hide resolved
christothes
reviewed
May 15, 2024
sdk/eventhub/Azure.Messaging.EventHubs/src/EventHubsConnectionStringProperties.cs
Show resolved
Hide resolved
christothes
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to remove the restriction that the endpoint used in connection strings must resolve to a variant of
localhostwhen using the development emulator. A fix to parsing was also made to be resilient to an endpoint with no scheme that specifies a custom port. Previously, this would parse incorrectly and be rejected. The scenario is now detected and parsed.Also included is a package bump for the AMQP transport library and release prep for the Event Hubs core package.