Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCF Client/CoreWCF extension packages to use Azure Queue Storage as transport #42124

Merged
merged 18 commits into from
Apr 19, 2024
Merged

WCF Client/CoreWCF extension packages to use Azure Queue Storage as transport #42124

merged 18 commits into from
Apr 19, 2024

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Feb 22, 2024 •
edited
Loading

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

This PR replaces #38291

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Feb 22, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

jsquire
jsquire requested changes Feb 22, 2024
View reviewed changes
eng/Packages.Data.props Show resolved Hide resolved
Packages.props Outdated Show resolved Hide resolved
Packages.Props Outdated Show resolved Hide resolved
eng/Directory.Build.Common.targets Outdated Show resolved Hide resolved
sdk/extensions/wcf/Microsoft.CoreWCF.Azure.StorageQueues/README.MD Outdated Show resolved Hide resolved
sdk/extensions/wcf/Directory.Build.targets Outdated Show resolved Hide resolved
sdk/extensions/wcf/Microsoft.WCF.Azure.StorageQueues/README.MD Outdated Show resolved Hide resolved
sdk/extensions/wcf/Microsoft.WCF.Azure.StorageQueues/README.MD Outdated Show resolved Hide resolved
...xtensions/wcf/Microsoft.WCF.Azure.StorageQueues/src/Microsoft.WCF.Azure.StorageQueues.csproj Show resolved Hide resolved
...s/wcf/Microsoft.WCF.Azure.StorageQueues/tests/Microsoft.WCF.Azure.StorageQueues.Tests.csproj Outdated Show resolved Hide resolved
@mconnew mconnew force-pushed the AQSBinding branch 3 times, most recently from f66a368 to 65a126c Compare February 26, 2024 21:18
jsquire
jsquire reviewed Feb 27, 2024
View reviewed changes
eng/Packages.Data.props Show resolved Hide resolved
sdk/extensions/wcf/Microsoft.CoreWCF.Azure.StorageQueues/README.md Outdated Show resolved Hide resolved
sdk/extensions/wcf/Microsoft.CoreWCF.Azure.StorageQueues/README.md Outdated Show resolved Hide resolved
...s/wcf/Microsoft.CoreWCF.Azure.StorageQueues/src/Microsoft.CoreWCF.Azure.StorageQueues.csproj Outdated Show resolved Hide resolved
...s/wcf/Microsoft.CoreWCF.Azure.StorageQueues/src/Microsoft.CoreWCF.Azure.StorageQueues.csproj Outdated Show resolved Hide resolved
...crosoft.CoreWCF.Azure.StorageQueues/tests/Microsoft.CoreWCF.Azure.StorageQueues.Tests.csproj Outdated Show resolved Hide resolved
...xtensions/wcf/Microsoft.WCF.Azure.StorageQueues/src/Microsoft.WCF.Azure.StorageQueues.csproj Show resolved Hide resolved
@mconnew
Copy link
Member Author

mconnew commented Mar 8, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 42124 in repo Azure/azure-sdk-for-net

@mconnew mconnew closed this Mar 8, 2024
@mconnew mconnew reopened this Mar 8, 2024
@jsquire jsquire dismissed their stale review April 12, 2024 14:58

Blocking concerns addressed. Waiting on test runs and final pass for approval.

@mconnew
Copy link
Member Author

mconnew commented Apr 15, 2024

The build failed because an unrelated test in a different project failed. The failing test is Azure.Storage.DataMovement.Tests.TransferValidationTests.LargeSingleFile_Fail_Destination(Download,Sequential).

@jsquire
Copy link
Member

jsquire commented Apr 16, 2024

The build failed because an unrelated test in a different project failed. The failing test is Azure.Storage.DataMovement.Tests.TransferValidationTests.LargeSingleFile_Fail_Destination(Download,Sequential).

I kicked that specific leg to avoid running the entire Core suite again.

jsquire
jsquire approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mconnew : Please let me know when you're ready to merge and I'll push the button.

subhra231 and others added 18 commits April 18, 2024 15:26
@subhra231 @mconnew
Add Azure Queue Storage support
e3dbd60
@mconnew
Added custom Credentials classes with binding support to choose crede…
d47fc7c 
…ntial type. Added tests
@mconnew
First round of PR feedback changes
23a589c
@subhra231 @mconnew
Addressing Review comments and fix test pipeline break
807899a
@mconnew
Update CoreWCF dependent package version
f362f8e
@mconnew
Fix problem with version pinning where type was removed in later vers…
8a74600 
…ion that NetFx asp.net core 2.1 needed
@subhra231 @mconnew
Changes to resolve PR comments
6b32644
@subhra231 @mconnew
Read me updated to fix validation errors
f59f3cc
@mconnew
Enable split build in extensions folder for aspnetcore and wcf
35e36c7
@mconnew
Remove Snippet annotation from documentation samples
3a45fcc
@mconnew
Fix old package version specified by existing SDK versions which brea…
9bf85c0 
…ks the WCF build
@mconnew
Fix readme url's to be relative so they don't point to main branch wh…
ba0cb77 
…ich doesn't exist yet
@mconnew
Added samples with snippets, fixed yml definitions
8d6a49c
@mconnew
Adding WCF docs to .docsettings.yml as well as CoreWCF
71f1311
@mconnew
Fix end2end dlq test which didn't have credentials configured
ce5dcea
@mconnew @weshaggard
Apply suggestions from code review
b3b13a8 
Co-authored-by: Wes Haggard <[email protected]>
@mconnew @scottaddie
Apply suggestions from code review
bbe6e5f 
Co-authored-by: Scott Addie <[email protected]>
@mconnew
Fixed readme, fixed folder separator to be / instead of \ in service.…
680be1a 
…projects
@mconnew
Copy link
Member Author

mconnew commented Apr 18, 2024

@jsquire I had to push an update as there was a merge conflict and needed to rebase. Nothing changed other than to resolve the merge conflict in Packages.Data.Props. Once the PR is successful, please merge when you can.

@mconnew
Copy link
Member Author

mconnew commented Apr 19, 2024

This failed again on unrelated tests. This time there are two tests with the name Champion_OneShotUpload that failed with a TimeoutException on Ubuntu.

@jsquire
Copy link
Member

jsquire commented Apr 19, 2024

This failed again on unrelated tests. This time there are two tests with the name Champion_OneShotUpload that failed with a TimeoutException on Ubuntu.

Welcome to the fun of the Azure.Core pipeline - where flaky tests from unrelated packages add some spice to your day. I'll kick and run them again.

@jsquire
Copy link
Member

jsquire commented Apr 19, 2024

/check-enforcer override

@jsquire
Copy link
Member

jsquire commented Apr 19, 2024

Failure is a flaky test from a library not impacted by these changes which is exceeding the global test timeout. Unfortunately, because the failure is triggered in test infrastructure, there isn't an indication in the stack trace which library this belongs to, causing difficulty to marking it to be ignored and filing an issue.

Merging these changes.

@jsquire jsquire merged commit 82cc7cf into Azure:main Apr 19, 2024
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@amnguye amnguye amnguye left review comments

@jsquire jsquire jsquire approved these changes

@scottaddie scottaddie scottaddie approved these changes

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft annelo-msft is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@pallavit pallavit Awaiting requested review from pallavit

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mconnew @azure-sdk @weshaggard @jsquire @scottaddie @amnguye @subhra231