Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Azure.Core ClientOptions.cs comments. Fix typo and use Entra ID term in Azure.AI.OpenAI readme. #41908

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Fix typo in Azure.Core ClientOptions.cs comments. Fix typo and use Entra ID term in Azure.AI.OpenAI readme. #41908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
512e78b
Minor README.md & source code comment fixes
dargilco Feb 12, 2024
b23d431
Merge remote-tracking branch 'origin/main' into dargilco/2-12-minor-f…
dargilco Feb 12, 2024
442c95c
Typo fix in azure.core
dargilco Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/src/ClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ protected ClientOptions(): this(Default, null)
}

/// <summary>
/// Creates a new instance of <see cref="ClientOptions"/> with the specificed <see cref="DiagnosticsOptions"/>.
/// Creates a new instance of <see cref="ClientOptions"/> with the specified <see cref="DiagnosticsOptions"/>.
/// </summary>
/// <param name="diagnostics"><see cref="DiagnosticsOptions"/> to be used for <see cref="Diagnostics"/>.</param>
protected ClientOptions(DiagnosticsOptions? diagnostics)
Expand Down
6 changes: 3 additions & 3 deletions sdk/openai/Azure.AI.OpenAI/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ OpenAIClient client = useAzureOpenAI
: new OpenAIClient("your-api-key-from-platform.openai.com");
```

#### Create OpenAIClient with an Azure Active Directory Credential
#### Create OpenAIClient with a Microsoft Entra ID Credential

Client subscription key authentication is used in most of the examples in this getting started guide, but you can also authenticate with Azure Active Directory using the [Azure Identity library][azure_identity]. To use the [DefaultAzureCredential][azure_identity_dac] provider shown below,
Client subscription key authentication is used in most of the examples in this getting started guide, but you can also authenticate with Microsoft Entra ID (formerly Azure Active Directory) using the [Azure Identity library][azure_identity]. To use the [DefaultAzureCredential][azure_identity_dac] provider shown below,
or other credential providers provided with the Azure SDK, please install the Azure.Identity package:

```dotnetcli
Expand Down Expand Up @@ -380,7 +380,7 @@ Additionally: if you would like to control the behavior of tool calls, you can u
- Providing a reference to a named function definition or function tool definition, as below, will instruct the model
to restrict its response to calling the corresponding tool. When calling tools in this configuration, response
`ChatChoice` instances will report a `FinishReason` of `CompletionsFinishReason.Stopped` and the corresponding
`ToolCalls` property will be populated Note that, because the model was constrained to a specific tool, it does
`ToolCalls` property will be populated. Note that, because the model was constrained to a specific tool, it does
**NOT** report the same `CompletionsFinishReason` value of `ToolCalls` expected when using
`ChatCompletionsToolChoice.Auto`.

Expand Down
Loading