ClientModel Prototype: Move response buffering to transport #41651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…core2-move-buffering-to-transport
…core2-move-buffering-to-transport
annelo-msft
commented
Jan 30, 2024
annelo-msft
commented
Jan 30, 2024
| _transport = new AzureCorePipelineTransport(this); | ||
| } | ||
|
|
||
| internal void ProcessInternal(HttpMessage message) |
There was a problem hiding this comment.
This effectively retroactively implements the template method and allows us to use ClientModel PipelineTransport validations in the Azure.Core abstract transport type. This gives us buffering in the default pipeline even for custom subtypes of HttpPipelineTransport.
annelo-msft
commented
Jan 30, 2024
annelo-msft
commented
Jan 30, 2024
annelo-msft
commented
Jan 30, 2024
annelo-msft
commented
Jan 30, 2024
annelo-msft
commented
Jan 31, 2024
…core2-move-buffering-to-transport
|
Closing in favor of #41907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.