ClientModel: Add retry classification to MessageClassifier #41586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
commented
Jan 26, 2024
annelo-msft
commented
Jan 26, 2024
sdk/core/System.ClientModel/src/Options/PipelineMessageClassifier.cs
Outdated
Show resolved
Hide resolved
annelo-msft
requested review from
KrzysztofCwalina,
tg-msft,
JoshLove-msft and
christothes
as code owners
KrzysztofCwalina
approved these changes
Jan 26, 2024
sdk/core/System.ClientModel/src/Options/PipelineMessageClassifier.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Jan 26, 2024
annelo-msft
commented
Jan 26, 2024
| ChainingClassifier classifier = new ChainingClassifier(last); | ||
| classifier.AddClassifier(new RetriableStatusCodeClassifier(429, isRetriable: false)); | ||
| classifier.AddClassifier(new ErrorStatusCodeClassifier(404, isError: false)); | ||
| classifier.AddClassifier(new ErrorStatusCodeClassifier(201, isError: true)); |
There was a problem hiding this comment.
With the new API, we can create a classifier that composes retry and error classifiers in a chain.
annelo-msft
commented
Jan 26, 2024
|
|
||
| message.SetResponse(new MockPipelineResponse(200)); | ||
| Assert.IsTrue(classifier.TryClassify(message, out bool isError)); | ||
| Assert.IsTrue(classifier.TryClassify(message, exception: default, out bool isRetriable)); |
There was a problem hiding this comment.
ClientModel pipeline policies will call these APIs to determine if a response is an error response, or a response is retriable, as shown here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the API for PipelineResponseClassifier in two ways:
Since we had previously put default retry classification in the ClientRetryPolicy, this is removed in favor of using the classifier on the message.
Addresses #41465