Mark log exporter class public #41553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
vishweshbankwar
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
TimothyMothra
as code owners
My personal opinion, if we do this for one Exporter we should do this for all three signals. |
rajkumar-rangaraj
approved these changes
Jan 25, 2024
vishweshbankwar
requested review from
KrzysztofCwalina and
tg-msft
as code owners
We could consider making trace one public in future if there is a need. There is no benefit in making the metric one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks log exporter class public. This will allow users to write their custom processor for filtering the logs.
TODO: Add changelog