Prototype: Composable retry classifiers - enable composition in Azure.Core #41542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
commented
Jan 24, 2024
| context.AddClassifier(404, false); | ||
| context.AddClassifier(500, false); | ||
| context.AddClassifier(new RetryClassificationHandler()); | ||
| context.AddClassifier(new StatusCodeHandler(404, true)); |
There was a problem hiding this comment.
Illustrates how an end-user would compose retriable-response and error-response classifiers using handler approach. Note that adding a handler via this interface means that we must use a ChainingClassifier for both retry and error classifications. This adds performance overhead to the optimized StatusCodeClassifier for when classifying errors for all calls to pipeline.Send for this operation.
An implementation that lets users customize retry classification without impacting error classification performance might be preferable.
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
changed the title
…clientmodel-compose-retryclassifiers
…clientmodel-compose-retryclassifiers
This was referenced Jan 26, 2024
|
Closing in favor of #41595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation into issue #41465