-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientModel: Add transport and buffering policy to System.ClientModel #41223
Merged
annelo-msft
merged 42 commits into
Azure:main
from
annelo-msft:clientmodel-add-transport
Jan 16, 2024
Merged
ClientModel: Add transport and buffering policy to System.ClientModel #41223
annelo-msft
merged 42 commits into
Azure:main
from
annelo-msft:clientmodel-add-transport
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check APIView has identified API level changes in this PR and created following API reviews. |
christothes
reviewed
Jan 12, 2024
sdk/core/System.ClientModel/src/Pipeline/HttpClientPipelineTransport.Request.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Jan 12, 2024
sdk/core/System.ClientModel/src/Pipeline/HttpClientPipelineTransport.Request.cs
Show resolved
Hide resolved
christothes
reviewed
Jan 12, 2024
sdk/core/System.ClientModel/src/Pipeline/HttpClientPipelineTransport.Response.cs
Show resolved
Hide resolved
christothes
reviewed
Jan 12, 2024
sdk/core/System.ClientModel/src/Pipeline/HttpClientPipelineTransport.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 12, 2024
annelo-msft
commented
Jan 13, 2024
sdk/core/System.ClientModel/src/NetStandardPolyfill/NotNullWhenAttribute.cs
Outdated
Show resolved
Hide resolved
sdk/core/System.ClientModel/src/NetStandardPolyfill/TrimmingAttribute.cs
Show resolved
Hide resolved
sdk/core/System.ClientModel/src/Pipeline/ResponseBufferingPolicy.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Jan 16, 2024
This was referenced Jan 16, 2024
Closed
christothes
approved these changes
Jan 16, 2024
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the implementation of the HttpClient transport to the System.ClientModel library, as well as the ResponseBufferingPolicy. Together these provide a functional default pipeline (without retries) so we can add functional tests of the pipeline as well.
Please note that we're working on an outstanding investigation regarding whether we can move the buffering and network timeout logic out of the response buffering policy and into the transport. That work is tracked by #41198. Depending on the outcome of that investigation, we may follow up and remove the ResponseBufferingPolicy entirely. The functional implementation would remain the same just in a different place, so it is still worth reviewing in this PR in order to make forward progress on moving ClientModel into main prior to this investigation being complete.
This PR adds the public types:
HttpClientPipelineTransport
ResponseBufferingPolicy
(pending removal based on the outcome of ClientModel: Investigate feasibility of moving response buffering into the transport #41198)and internal types:
PipelineRequestHeaders
PipelineResponseHeaders
HttpClientPipelineTransport.HttpPipelineRequest
HttpClientPipelineTransport.HttpPipelineResponse