Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientModel: Add transport and buffering policy to System.ClientModel #41223

Merged
merged 42 commits into from
Jan 16, 2024

Conversation

annelo-msft
Copy link
Member

@annelo-msft annelo-msft commented Jan 12, 2024

Add the implementation of the HttpClient transport to the System.ClientModel library, as well as the ResponseBufferingPolicy. Together these provide a functional default pipeline (without retries) so we can add functional tests of the pipeline as well.

Please note that we're working on an outstanding investigation regarding whether we can move the buffering and network timeout logic out of the response buffering policy and into the transport. That work is tracked by #41198. Depending on the outcome of that investigation, we may follow up and remove the ResponseBufferingPolicy entirely. The functional implementation would remain the same just in a different place, so it is still worth reviewing in this PR in order to make forward progress on moving ClientModel into main prior to this investigation being complete.

This PR adds the public types:

and internal types:

  • PipelineRequestHeaders
  • PipelineResponseHeaders
  • HttpClientPipelineTransport.HttpPipelineRequest
  • HttpClientPipelineTransport.HttpPipelineResponse

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 12, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

System.ClientModel

@annelo-msft annelo-msft merged commit 08ac84b into Azure:main Jan 16, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants