Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore point create and delete API #4119

Closed
wants to merge 2 commits into from

Conversation

sarvesh-s
Copy link
Contributor

@sarvesh-s sarvesh-s commented Mar 9, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need test for delete, otherwise looks good :)


1) azure-rest-api-specs repository information
GitHub user: kosta-bizetic
GitHub user: Azure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvesh-s please pull from upstream and regenerate using generate.cmd
It has the fix to get you the commit id for your generation

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some breaking changes introduced here. Please bump the package version to 1.13.0-preview in the csproj file.
Please pull down the latest changes from upstream and run
msbuild build.proj /t:build /p:Scope=SDKs\SqlManagement
This should update the .props file. Please commit these changes.

@shahabhijeet
Copy link
Member

@sarvesh-s we will do a final review as soon as @jaredmoo approves this PR

@shahabhijeet
Copy link
Member

@sarvesh-s this PR needs your attention. If you are not able to move forward, I request you to close this PR and open it when it's ready to be reviewed and signed off in due to time by your team.
This PR will be closed by EOW

@sarvesh-s
Copy link
Contributor Author

I updated the PR, now I only have a test change. Rest of the code was already merged as part of different PR, @shahabhijeet

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why
src/SDKs/_metadata/sql_resource-manager.txt
is a binary file in your PR?

@sarvesh-s
Copy link
Contributor Author

@jaredmoo Any idea why its binary file shown here as I don't see it locally, its plain text for me

@jaredmoo
Copy link
Contributor

jaredmoo commented Mar 23, 2018

git fetch --all
git reset --hard jaredmoo/sarvesh-fix

Then force push to your fork repo

@sarvesh-s sarvesh-s closed this Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants