Add Pipeline Types to System.ClientModel library #41085
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
requested review from
KrzysztofCwalina,
tg-msft,
JoshLove-msft and
christothes
as code owners
annelo-msft
requested review from
jsquire,
AlexanderSher,
pallavit and
m-nash
sdk/core/System.ClientModel/src/Options/ClientPipelineOptions.cs
Outdated
Show resolved
Hide resolved
sdk/core/System.ClientModel/src/Internal/ArrayBackedPropertyBag.cs
Outdated
Show resolved
Hide resolved
sdk/core/System.ClientModel/src/Internal/ArrayBackedPropertyBag.cs
Outdated
Show resolved
Hide resolved
|
Since this merged as comments were still coming in on resolved threads, if there are any outstanding comments that didn't get addressed but are important and not covered by issues in the ClientModel backlog, please feel free to file an issue to track, or also you're welcome to put up a PR into main to address targeted areas of interest! Thanks! |
|
|
||
| public override async Task WriteToAsync(Stream stream, CancellationToken cancellation) | ||
| { | ||
| if (_model is IJsonModel<T> && _options.Format == "J") |
There was a problem hiding this comment.
I think we should perhaps expose this functionality in an internal static method on MRW so that we can duplicate the logic. It will have a higher hit rate on the faster API which will be a good thing.
There was a problem hiding this comment.
Per offline discussion, will address in a separate PR, and thanks for raising, @m-nash!
Add basic pipeline types to the System.ClientModel library, including:
ClientPipelineClientPipelineOptionsPipelinePolicyPipelineTransportPipelineMessagePipelineRequestBinaryContentA discussion of the types contained in this PR can be found in the System.ClientModel README.