Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delete Invalid Room Test case #37887

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Fix Delete Invalid Room Test case #37887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
377f6b2
Increase Rooms .Net SDK code coverage
Jul 27, 2023
af78af1
List Room get first two pages
Jul 27, 2023
1867e99
Fix delete invalid room test
Jul 27, 2023
64e84f1
Merge branch 'main' into peiliu/increaseCodeCoverage
Jul 27, 2023
79ac2c8
Remove unneeded recordings
Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/communication/Azure.Communication.Rooms/tests/RoomsClient/RoomsClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,16 +659,16 @@ public async Task DeleteRoom_Success()
}

[Test]
public void DeleteRoomDoesNotExist_Fail()
public void DeleteInvalidRoomId_Fail()
{
// Arrange
var roomsClient = CreateInstrumentedRoomsClient(RoomsClientOptions.ServiceVersion.V2023_06_14);
var ivnalidRoomId = "99437728598278806";
var ivnalidRoomId = "123";

// Act and Assert:
RequestFailedException? ex = Assert.ThrowsAsync<RequestFailedException>(async () => await roomsClient.DeleteRoomAsync(ivnalidRoomId));
Assert.NotNull(ex);
Assert.AreEqual(404, ex?.Status);
Assert.AreEqual(400, ex?.Status);
}

private void ValidateRoom(CommunicationRoom? room)
Expand Down
22 changes: 11 additions & 11 deletions ...iveTests/DeleteRoomDoesNotExist_Fail.json → ...ntLiveTests/DeleteInvalidRoomId_Fail.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions ...sts/DeleteRoomDoesNotExist_FailAsync.json → ...eTests/DeleteInvalidRoomId_FailAsync.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.