Autorest Regen Preview to 3.0.0-alpha.20230713.1 by Mingzhe Huang from refs/pull/3584/head #37584
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Health.Insights.ClinicalMatching |
- update api signature - add repeatable request headers into ignored headers of tests
|
The above SDKs are all in beta release. And |
- fix API invocation due to removal of repeatability header parameters - remove `RepeatabilityHeaders` class and its tests since it is not necessary
| public virtual Azure.Operation<Azure.Health.Insights.CancerProfiling.OncoPhenotypeResult> InferCancerProfile(Azure.WaitUntil waitUntil, Azure.Health.Insights.CancerProfiling.OncoPhenotypeData oncoPhenotypeData, string repeatabilityRequestId = null, System.DateTimeOffset? repeatabilityFirstSent = default(System.DateTimeOffset?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; } | ||
| public virtual System.Threading.Tasks.Task<Azure.Operation<System.BinaryData>> InferCancerProfileAsync(Azure.WaitUntil waitUntil, Azure.Core.RequestContent content, string repeatabilityRequestId = null, System.DateTimeOffset? repeatabilityFirstSent = default(System.DateTimeOffset?), Azure.RequestContext context = null) { throw null; } | ||
| public virtual System.Threading.Tasks.Task<Azure.Operation<Azure.Health.Insights.CancerProfiling.OncoPhenotypeResult>> InferCancerProfileAsync(Azure.WaitUntil waitUntil, Azure.Health.Insights.CancerProfiling.OncoPhenotypeData oncoPhenotypeData, string repeatabilityRequestId = null, System.DateTimeOffset? repeatabilityFirstSent = default(System.DateTimeOffset?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; } | ||
| public virtual Azure.Operation<System.BinaryData> InferCancerProfile(Azure.WaitUntil waitUntil, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; } |
There was a problem hiding this comment.
I think this is the right fix but this would cause breaking change to health insight. @m-nash, do you have any concern for this change?
There was a problem hiding this comment.
I think this is the right fix but this would cause breaking change to health insight. @m-nash, do you have any concern for this change?
They are all beta versions. I think it's OK to change it.
There was a problem hiding this comment.
yeah since they are in beta this is fine and expected
There was a problem hiding this comment.
Hi,
It is ok by us that the repeatability headers will be set internally.
Related to the above change, I see that the Sync method was generated but the Async method dropped.
Any reason why?
Also, a question: is there an option to set the repeatability headers as context policy? (not see it used, it is just my curiosity)
There was a problem hiding this comment.
Hi @asaflevi-ms are you referring to ClinicalMatchingClient? Which method do you refer to?
There are 4 methods being changed. 2 of them are sync methods, and other 2 are async methods.
As for the policy, the answer is yes. Users are free to set a pipeline policy through RequestContext. See here for example: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/RequestContext.md#add-policy-for-request
There was a problem hiding this comment.
Hi @archerzz
My mistake, I missed it.
I reviewed HealthInsights clients (ClinicalMatchingClient and CancerProfilingClient).
Approved by me.
…cation.CallingServer` tests
- reverts commit 015e75d - add backward compatible methods of `ChatRestClient` which still accepts incoming `repeatability-request-id` - revert change on test case base
- update test recordings to add repeatability request headers - change test case base to use `IgnoredHeaders` instead of `LegacyExcludedHeaders`
- update test recordings to add repeatability request headers - change test case base to use `IgnoredHeaders` instead of `LegacyExcludedHeaders`
|
Close since the changes have been merged in #37746 |
Triggered from Azure/autorest.csharp#3584