Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetAppFiles]Update to 2022-11-01 #37433

Merged

Conversation

audunn
Copy link
Member

@audunn audunn commented Jul 6, 2023

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.NetApp

@audunn
Copy link
Member Author

audunn commented Jul 6, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 37433 in repo Azure/azure-sdk-for-net

@audunn
Copy link
Member Author

audunn commented Jul 6, 2023

Not sure why the failure is happening in the pipeline, the failing test is not part of this PR Azure.Core.Tests.ExponentialPolicyTest(False).DoesNotAdvanceHostWhenAdvancedByOtherThread

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@pallavit
Copy link
Contributor

@audunn Thank you for the patience.

Now that we are past the asset move , /cc: @ArthurMa1978 - for help with review of the mgmt plane SDK.

@audunn
Copy link
Member Author

audunn commented Jul 19, 2023

@pallavit Do you mind elaborating a bit on what fixed it. Was it the azure-sdk-write-netapp group or something else?

@audunn
Copy link
Member Author

audunn commented Jul 20, 2023

@ArcturusZhang Can you help identify the build issue cannot see where the problem is?

@scbedd
Copy link
Member

scbedd commented Jul 20, 2023

@pallavit Do you mind elaborating a bit on what fixed it. Was it the azure-sdk-write-netapp group or something else?

Exactly @audunn , our assets repo requires that you be part of one of the write groups. You hadn't been part of one up till that point, so we needed to create the appropriate group and assign you to it. As members of your team need to push additional assets, have them join that netapp group. Sorry the delay!

@audunn
Copy link
Member Author

audunn commented Jul 21, 2023

Thank you @scbedd

@audunn
Copy link
Member Author

audunn commented Jul 21, 2023

@ArcturusZhang Can you help identify the build issue cannot see where the problem is?

hmm seems to have resolved itself after re-running failed steps.

@audunn
Copy link
Member Author

audunn commented Jul 24, 2023

@ArcturusZhang Can you take a look at this, can we move on with this now or is there more to be done?

Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@audunn sorry for the delay of review - in general this PR looks good to me, I just left some minor comments about names of the new APIs, please take a look

@audunn
Copy link
Member Author

audunn commented Aug 10, 2023

@ArcturusZhang thanks for the review, can you have another look ?

@ArcturusZhang ArcturusZhang merged commit ea7dc0d into Azure:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants