-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NetAppFiles]Update to 2022-11-01 #37433
[NetAppFiles]Update to 2022-11-01 #37433
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run |
Commenter does not have sufficient privileges for PR 37433 in repo Azure/azure-sdk-for-net |
Not sure why the failure is happening in the pipeline, the failing test is not part of this PR |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
…o ANF-28965-NetAppFiles-ApiVersion-2020-11-01
@audunn Thank you for the patience. Now that we are past the asset move , /cc: @ArthurMa1978 - for help with review of the mgmt plane SDK. |
@pallavit Do you mind elaborating a bit on what fixed it. Was it the azure-sdk-write-netapp group or something else? |
@ArcturusZhang Can you help identify the build issue cannot see where the problem is? |
Exactly @audunn , our assets repo requires that you be part of one of the |
Thank you @scbedd |
hmm seems to have resolved itself after re-running failed steps. |
@ArcturusZhang Can you take a look at this, can we move on with this now or is there more to be done? |
sdk/netapp/Azure.ResourceManager.NetApp/api/Azure.ResourceManager.NetApp.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/netapp/Azure.ResourceManager.NetApp/api/Azure.ResourceManager.NetApp.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/netapp/Azure.ResourceManager.NetApp/api/Azure.ResourceManager.NetApp.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/netapp/Azure.ResourceManager.NetApp/api/Azure.ResourceManager.NetApp.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@audunn sorry for the delay of review - in general this PR looks good to me, I just left some minor comments about names of the new APIs, please take a look
…o ANF-28965-NetAppFiles-ApiVersion-2020-11-01
@ArcturusZhang thanks for the review, can you have another look ? |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.